-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Rules UI/UX improvements #592
[FEATURE] Rules UI/UX improvements #592
Conversation
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
@amsiglan Is this Sigma rules specs URl ok: https://sigmahq.github.io/sigma-specification/Sigma_specification.html |
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #592 +/- ##
=======================================
Coverage 31.47% 31.47%
=======================================
Files 138 138
Lines 4340 4340
Branches 723 773 +50
=======================================
Hits 1366 1366
Misses 2835 2835
Partials 139 139 |
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
…-analytics-dashboards-plugin into Rules_UI/UX_improvements # Conflicts: # public/app.scss
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-592-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1f8105dc80ddb5898fa1b42269244a5d0cfa4b06
# Push it to GitHub
git push --set-upstream origin backport/backport-592-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.8 2.8
# Navigate to the new working tree
cd .worktrees/backport-2.8
# Create a new branch
git switch --create backport/backport-592-to-2.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1f8105dc80ddb5898fa1b42269244a5d0cfa4b06
# Push it to GitHub
git push --set-upstream origin backport/backport-592-to-2.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.8 Then, create a pull request where the |
* [FEATURE] Rules UI/UX improvements opensearch-project#585 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] Detection rules page | Filter name typo opensearch-project#588 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
* [FEATURE] Rules UI/UX improvements opensearch-project#585 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] Detection rules page | Filter name typo opensearch-project#588 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
* Detection rule new detection ux (#575) (#596) * basic framework ready Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * working without validation Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * detection rule updates Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detection rule updates Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detection rule updates Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * added validation for duplicate keys; do not submit if detection has errors Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * validations added Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * more validations Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * comment update Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> (cherry picked from commit feb0ed7) Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * cypress tests update (#581) Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Update selection panel component for the "Create detection rule" (#594) * [FEATURE] Update selection panel component for the "Create detection rule" page #587 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Update selection panel component for the "Create detection rule" page #587 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Update selection panel component for the "Create detection rule" page #587 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Update selection panel component for the "Create detection rule" page #587 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Rules UI/UX improvements (#592) * [FEATURE] Rules UI/UX improvements #585 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] Detection rules page | Filter name typo #588 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
…ch-project#609) * [FEATURE] Rules UI/UX improvements opensearch-project#585 * [BUG] Detection rules page | Filter name typo opensearch-project#588 * Code review --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Description
Adds the rules UI/UX improvements:
The page heading should read the "Create detection rule"
Remove the line under the "Create detection rule" heading
Breadcrumbs should read: Security Analytics > Detection rules > Create detection rule
The title of the table should read "Detection rules"
Make sure that sidebar reads "Detection rules"
Issues Resolved
Resolves #585
Resolves #588
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.