Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Rules UI/UX improvements #592

Merged

Conversation

jovancacvetkovic
Copy link
Contributor

@jovancacvetkovic jovancacvetkovic commented May 19, 2023

Description

Adds the rules UI/UX improvements:

The page heading should read the "Create detection rule"
Remove the line under the "Create detection rule" heading
Breadcrumbs should read: Security Analytics > Detection rules > Create detection rule
The title of the table should read "Detection rules"
Make sure that sidebar reads "Detection rules"

Issues Resolved

Resolves #585
Resolves #588

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
@jovancacvetkovic
Copy link
Contributor Author

@amsiglan Is this Sigma rules specs URl ok: https://sigmahq.github.io/sigma-specification/Sigma_specification.html

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #592 (a8cd869) into main (9831c8f) will not change coverage.
The diff coverage is n/a.

❗ Current head a8cd869 differs from pull request most recent head 645d776. Consider uploading reports for the commit 645d776 to get more accurate results

@@           Coverage Diff           @@
##             main     #592   +/-   ##
=======================================
  Coverage   31.47%   31.47%           
=======================================
  Files         138      138           
  Lines        4340     4340           
  Branches      723      773   +50     
=======================================
  Hits         1366     1366           
  Misses       2835     2835           
  Partials      139      139           

see 1 file with indirect coverage changes

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
@AWSHurneyt AWSHurneyt merged commit 1f8105d into opensearch-project:main May 30, 2023
9 of 11 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-592-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1f8105dc80ddb5898fa1b42269244a5d0cfa4b06
# Push it to GitHub
git push --set-upstream origin backport/backport-592-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-592-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.8 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.8 2.8
# Navigate to the new working tree
cd .worktrees/backport-2.8
# Create a new branch
git switch --create backport/backport-592-to-2.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1f8105dc80ddb5898fa1b42269244a5d0cfa4b06
# Push it to GitHub
git push --set-upstream origin backport/backport-592-to-2.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.8

Then, create a pull request where the base branch is 2.8 and the compare/head branch is backport/backport-592-to-2.8.

amsiglan pushed a commit to amsiglan/security-analytics-dashboards-plugin that referenced this pull request May 30, 2023
* [FEATURE] Rules UI/UX improvements opensearch-project#585

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detection rules page | Filter name typo opensearch-project#588

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Code review

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
amsiglan pushed a commit to amsiglan/security-analytics-dashboards-plugin that referenced this pull request May 30, 2023
* [FEATURE] Rules UI/UX improvements opensearch-project#585

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detection rules page | Filter name typo opensearch-project#588

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Code review

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
AWSHurneyt pushed a commit that referenced this pull request May 30, 2023
* [FEATURE] Rules UI/UX improvements #585



* [BUG] Detection rules page | Filter name typo #588



* Code review



---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
AWSHurneyt pushed a commit that referenced this pull request May 30, 2023
* Detection rule new detection ux (#575) (#596)

* basic framework ready

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* working without validation

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* detection rule updates

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* detection rule updates

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* detection rule updates

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* added validation for duplicate keys; do not submit if detection has errors

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* validations added

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* more validations

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* comment update

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

---------

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
(cherry picked from commit feb0ed7)

Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* cypress tests update (#581)

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Update selection panel component for the "Create detection rule" (#594)

* [FEATURE] Update selection panel component for the "Create detection rule" page #587

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update selection panel component for the "Create detection rule" page #587

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update selection panel component for the "Create detection rule" page #587

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update selection panel component for the "Create detection rule" page #587

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Rules UI/UX improvements (#592)

* [FEATURE] Rules UI/UX improvements #585

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detection rules page | Filter name typo #588

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Code review

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…ch-project#609)

* [FEATURE] Rules UI/UX improvements opensearch-project#585



* [BUG] Detection rules page | Filter name typo opensearch-project#588



* Code review



---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Detection rules page | Filter name typo [FEATURE] Rules UI/UX improvements
3 participants