[Backport 2.8] PRs 575, 581, 592, 594 #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…project#596) * basic framework ready Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * working without validation Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * detection rule updates Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detection rule updates Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detection rule updates Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * added validation for duplicate keys; do not submit if detection has errors Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * validations added Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * more validations Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * comment update Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> (cherry picked from commit feb0ed7) Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
…nsearch-project#594) * [FEATURE] Update selection panel component for the "Create detection rule" page opensearch-project#587 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Update selection panel component for the "Create detection rule" page opensearch-project#587 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Update selection panel component for the "Create detection rule" page opensearch-project#587 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Update selection panel component for the "Create detection rule" page opensearch-project#587 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
* [FEATURE] Rules UI/UX improvements opensearch-project#585 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] Detection rules page | Filter name typo opensearch-project#588 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Codecov Report
@@ Coverage Diff @@
## 2.8 #608 +/- ##
==========================================
- Coverage 32.45% 31.46% -0.99%
==========================================
Files 137 138 +1
Lines 4126 4335 +209
Branches 726 771 +45
==========================================
+ Hits 1339 1364 +25
- Misses 2648 2832 +184
Partials 139 139 |
AWSHurneyt
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backporting PRs #575, #581, #592, #594
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.