UX updates for correlations #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #619 +/- ##
==========================================
- Coverage 31.48% 31.31% -0.18%
==========================================
Files 138 138
Lines 4335 4375 +40
Branches 721 778 +57
==========================================
+ Hits 1365 1370 +5
- Misses 2832 2867 +35
Partials 138 138 |
AWSHurneyt
reviewed
Jun 2, 2023
There was a problem hiding this comment.
@amsiglan were the cypress tests failing only on the main branch?
public/pages/Findings/components/FindingsTable/FindingsTable.tsx
Outdated
Show resolved
Hide resolved
AWSHurneyt
reviewed
Jun 2, 2023
There was a problem hiding this comment.
@amsiglan were the cypress tests failing only on the main branch?
AWSHurneyt
approved these changes
Jun 2, 2023
|
@amsiglan Does this PR need to be backported to any branches other than 2.x? |
No |
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
sbcd90
approved these changes
Jun 22, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 22, 2023
* minor UX updates Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * ux improvements for correlations Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * made more refactors for ux polish Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshots Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * addressed comments in PR Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 205ee18)
amsiglan
added a commit
that referenced
this pull request
Jul 11, 2023
* minor UX updates Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * ux improvements for correlations Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * made more refactors for ux polish Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshots Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * addressed comments in PR Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 205ee18) Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
opensearch-trigger-bot bot
added a commit
that referenced
this pull request
Jul 11, 2023
* minor UX updates Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * ux improvements for correlations Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * made more refactors for ux polish Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshots Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * addressed comments in PR Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 205ee18) Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 65ea940)
amsiglan
pushed a commit
that referenced
this pull request
Jul 12, 2023
* minor UX updates Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * ux improvements for correlations Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * made more refactors for ux polish Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshots Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * addressed comments in PR Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 205ee18) Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 65ea940) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…ect#635) (opensearch-project#642) * minor UX updates Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * ux improvements for correlations Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * made more refactors for ux polish Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshots Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * addressed comments in PR Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 205ee18) Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 65ea940) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes minor improvements throughout the correlations worflow
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.