Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend yaml mime type #909

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Extend yaml mime type #909

merged 2 commits into from
Mar 12, 2024

Conversation

amsiglan
Copy link
Collaborator

Description

Sometimes the file type for the imported yaml file can be one of the deprecated types (text/yaml, text/x-yaml) based on user's browser due to which we report the error for unsupported file. This PR also checks for these MIME types for yaml.

Issues Resolved

#844

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

riysaxen-amzn
riysaxen-amzn approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@riysaxen-amzn riysaxen-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov Codecov
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.05%. Comparing base (d3aefba) to head (fe7c095).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #909      +/-   ##
==========================================
+ Coverage   31.03%   31.05%   +0.01%     
==========================================
  Files         157      157              
  Lines        5229     5230       +1     
  Branches      981      981              
==========================================
+ Hits         1623     1624       +1     
  Misses       3419     3419              
  Partials      187      187

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amsiglan amsiglan merged commit 3812afd into opensearch-project:main Mar 12, 2024
9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 12, 2024
@github-actions
added more mime types for yaml file (#909)
09dc25e 
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
(cherry picked from commit 3812afd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 12, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 12, 2024
@github-actions
added more mime types for yaml file (#909)
c80c6a3 
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
(cherry picked from commit 3812afd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 12, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 12, 2024
@github-actions
added more mime types for yaml file (#909)
4bf5003 
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
(cherry picked from commit 3812afd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 12, 2024
@github-actions
added more mime types for yaml file (#909)
68b49c2 
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
(cherry picked from commit 3812afd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Mar 12, 2024
Merged
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 12, 2024
@github-actions
added more mime types for yaml file (#909)
bde13ab 
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
(cherry picked from commit 3812afd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 12, 2024
@github-actions
added more mime types for yaml file (#909)
308bd9f 
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
(cherry picked from commit 3812afd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Mar 12, 2024
Merged
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 12, 2024
@github-actions
added more mime types for yaml file (#909)
23b399e 
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
(cherry picked from commit 3812afd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 12, 2024
Merged
amsiglan added a commit that referenced this pull request Mar 12, 2024
@amsiglan
added more mime types for yaml file (#909)
382e70b 
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan pushed a commit that referenced this pull request Mar 13, 2024
@opensearch-trigger-bot @github-actions
added more mime types for yaml file (#909) (#916)
8163803 
(cherry picked from commit 3812afd)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Mar 13, 2024
@opensearch-trigger-bot @github-actions
added more mime types for yaml file (#909) (#915)
2a91c6a 
(cherry picked from commit 3812afd)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Mar 13, 2024
@opensearch-trigger-bot @github-actions
added more mime types for yaml file (#909) (#913)
ec77ca1 
(cherry picked from commit 3812afd)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan added a commit that referenced this pull request Mar 13, 2024
@opensearch-trigger-bot @github-actions @amsiglan
added more mime types for yaml file (#909) (#911)
82a0bd4 
(cherry picked from commit 3812afd)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan added a commit that referenced this pull request Mar 13, 2024
@opensearch-trigger-bot @github-actions @amsiglan
added more mime types for yaml file (#909) (#912)
1e65337 
(cherry picked from commit 3812afd)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
@zu3st zu3st mentioned this pull request Mar 14, 2024
Closed
amsiglan added a commit that referenced this pull request Mar 15, 2024
@opensearch-trigger-bot @github-actions @amsiglan
added more mime types for yaml file (#909) (#910)
0427fe9 
(cherry picked from commit 3812afd)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan added a commit that referenced this pull request Mar 16, 2024
@opensearch-trigger-bot @github-actions @amsiglan
added more mime types for yaml file (#909) (#910)
58727cd 
(cherry picked from commit 3812afd)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan added a commit that referenced this pull request Apr 10, 2024
@opensearch-trigger-bot @github-actions @amsiglan
added more mime types for yaml file (#909) (#914)
31dc3fa 
(cherry picked from commit 3812afd)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riysaxen-amzn riysaxen-amzn riysaxen-amzn approved these changes

@AWSHurneyt AWSHurneyt AWSHurneyt approved these changes

@getsaurabh02 getsaurabh02 Awaiting requested review from getsaurabh02 getsaurabh02 is a code owner

@lezzago lezzago Awaiting requested review from lezzago lezzago is a code owner

@praveensameneni praveensameneni Awaiting requested review from praveensameneni praveensameneni is a code owner

@sbcd90 sbcd90 Awaiting requested review from sbcd90 sbcd90 is a code owner

@eirsep eirsep Awaiting requested review from eirsep eirsep is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.7 backport 2.8 backport 2.9 backport 2.10 backport 2.11 PRs to be backported to 2.11 branch backport 2.12
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amsiglan @riysaxen-amzn @AWSHurneyt