Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show index-pattern creation form once created when viewing surrounding docs #927

Conversation

amsiglan
Copy link
Collaborator

Description

Currently once the index pattern gets created, the state is not getting updated correctly due to which if the user returns to the finding flyout and clicks view surrounding documents button again, we don't find the indexPatternId for the pattern just created and end up asking user to create the index-pattern again but since the pattern already exists the creation fails silently and user gets stuck.

The change in this PR ensures we re-render the flyout with the new state after index pattern creation so that the next surrounding doc button click directly opens the discover window

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.05%. Comparing base (fdfc904) to head (8847f87).
Report is 1 commits behind head on main.

❗ Current head 8847f87 differs from pull request most recent head c0495d0. Consider uploading reports for the commit c0495d0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #927      +/-   ##
==========================================
- Coverage   31.15%   31.05%   -0.10%     
==========================================
  Files         158      157       -1     
  Lines        5242     5232      -10     
  Branches      976      982       +6     
==========================================
- Hits         1633     1625       -8     
+ Misses       3436     3420      -16     
- Partials      173      187      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amsiglan
Copy link
Collaborator Author

Passing cypress tests:
image

@amsiglan
Copy link
Collaborator Author

Passing UTs:
image

@amsiglan amsiglan merged commit 16d11f3 into opensearch-project:main Mar 15, 2024
3 of 7 checks passed
@amsiglan amsiglan added backport 2.x backport 2.11 PRs to be backported to 2.11 branch backport 2.12 labels Mar 15, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 15, 2024
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
(cherry picked from commit 16d11f3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 15, 2024
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
(cherry picked from commit 16d11f3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 15, 2024
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
(cherry picked from commit 16d11f3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan added a commit that referenced this pull request Mar 16, 2024
(cherry picked from commit 16d11f3)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan added a commit that referenced this pull request Apr 10, 2024
(cherry picked from commit 16d11f3)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan added a commit that referenced this pull request Apr 10, 2024
(cherry picked from commit 16d11f3)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.11 PRs to be backported to 2.11 branch backport 2.12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants