-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show index-pattern creation form once created when viewing surrounding docs #927
Merged
amsiglan
merged 2 commits into
opensearch-project:main
from
amsiglan:dont-show-index-pattern-creation-form-once-created
Mar 15, 2024
Merged
Don't show index-pattern creation form once created when viewing surrounding docs #927
amsiglan
merged 2 commits into
opensearch-project:main
from
amsiglan:dont-show-index-pattern-creation-form-once-created
Mar 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep and
riysaxen-amzn
as code owners
March 13, 2024 23:36
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #927 +/- ##
==========================================
- Coverage 31.15% 31.05% -0.10%
==========================================
Files 158 157 -1
Lines 5242 5232 -10
Branches 976 982 +6
==========================================
- Hits 1633 1625 -8
+ Misses 3436 3420 -16
- Partials 173 187 +14 ☔ View full report in Codecov by Sentry. |
riysaxen-amzn
approved these changes
Mar 14, 2024
sbcd90
approved these changes
Mar 14, 2024
AWSHurneyt
approved these changes
Mar 14, 2024
…attern-creation-form-once-created
amsiglan
added
backport 2.x
backport 2.11
PRs to be backported to 2.11 branch
backport 2.12
labels
Mar 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 15, 2024
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 16d11f3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 15, 2024
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 16d11f3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 15, 2024
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 16d11f3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
added a commit
that referenced
this pull request
Mar 16, 2024
(cherry picked from commit 16d11f3) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
added a commit
that referenced
this pull request
Apr 10, 2024
(cherry picked from commit 16d11f3) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
added a commit
that referenced
this pull request
Apr 10, 2024
(cherry picked from commit 16d11f3) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently once the index pattern gets created, the state is not getting updated correctly due to which if the user returns to the finding flyout and clicks view surrounding documents button again, we don't find the indexPatternId for the pattern just created and end up asking user to create the index-pattern again but since the pattern already exists the creation fails silently and user gets stuck.
The change in this PR ensures we re-render the flyout with the new state after index pattern creation so that the next surrounding doc button click directly opens the discover window
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.