[Backport 2.x] fixed GetFindings not searching all indices; fixed proper deletion of… #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
eirsep
approved these changes
Nov 9, 2022
getsaurabh02
approved these changes
Nov 9, 2022
Codecov Report
@@ Coverage Diff @@
## 2.x #135 +/- ##
============================================
- Coverage 39.24% 39.23% -0.01%
- Complexity 882 884 +2
============================================
Files 176 176
Lines 6659 6677 +18
Branches 809 811 +2
============================================
+ Hits 2613 2620 +7
- Misses 3807 3816 +9
- Partials 239 241 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Feb 20, 2024
…ct#135) * Renamed test file based on feedback from functional test repo team. Removed unused method call. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Renamed test file based on feedback from functional test repo team. Removed unused import. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Renamed test file based on feedback from functional test repo team. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented additional cypress commands. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented example JSONs for use by integration tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented integration tests to validate alert and finding details flyout content. Implemented integration tests for acknowledging alerts. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Renamed test files to adjust the sequence of integration test executions. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed TODO for another test case. The function that would be tested by that case wouldn't be available from the alerts table page; it's only available from the findings table page, which will be a separate spec file. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed the text in a comment. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed redundant variables. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Deleted 4_findings.spec.js file from this PR as it's being implemented in a separate PR. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Adjusted data-test-subjs. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated import. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed data-test-subj used by test. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 8dd1c9f from #122