Feature/191 multiple detector types breaking change v1 #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #227 +/- ##
============================================
- Coverage 38.97% 38.58% -0.39%
- Complexity 892 898 +6
============================================
Files 176 176
Lines 6746 6896 +150
Branches 823 845 +22
============================================
+ Hits 2629 2661 +32
- Misses 3876 3990 +114
- Partials 241 245 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
stevanbz
force-pushed
the
feature/191-multiple-detector-types-breaking-change-v1
branch
from
3806a78
to
120e66f
Compare
5 tasks
stevanbz
force-pushed
the
feature/191-multiple-detector-types-breaking-change-v1
branch
2 times, most recently
from
d8997c4
to
17fa1af
Compare
Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
stevanbz
force-pushed
the
feature/191-multiple-detector-types-breaking-change-v1
branch
2 times, most recently
from
4b24acc
to
75997d4
Compare
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Feb 20, 2024
* [FEATURE] Common data store for the rules opensearch-project#473 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Common data store for the rules opensearch-project#473 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Common data store for the rules opensearch-project#473 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Common data store for the rules opensearch-project#473 Fix cypress create rules flaky tests opensearch-project#426 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Common data store for the rules opensearch-project#473 Fix cypress create rules flaky tests opensearch-project#426 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Common data store for the rules opensearch-project#474 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Common data store for the rules opensearch-project#474 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Common data store for the rules opensearch-project#474 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Common data store for the rules opensearch-project#474 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Common data store for the rules opensearch-project#474 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Communicate to users when detector is initializing opensearch-project#227 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Communicate to users when detector is initializing opensearch-project#227 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Common data store for the rules opensearch-project#473 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Common data store for the rules opensearch-project#473 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Common data store for the rules opensearch-project#474 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Common data store for the rules opensearch-project#474 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Feb 20, 2024
…oject#487) * [FEATURE] Communicate to users when detector is initializing opensearch-project#227 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Communicate to users when detector is initializing opensearch-project#227 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Communicate to users when detector is initializing opensearch-project#227 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Communicate to users when detector is initializing opensearch-project#227 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Common data store for the rules opensearch-project#474 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Communicate to users when detector is initializing opensearch-project#227 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Communicate to users when detector is initializing opensearch-project#227 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Communicate to users when detector is initializing opensearch-project#227 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Communicate to users when detector is initializing opensearch-project#227 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Communicate to users when detector is initializing opensearch-project#227 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Communicate to users when the detector is initializing opensearch-project#487 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
|
@sbcd90 , can you please review and update / close as needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added multiple detector types as part of DetectorInput. Extended detector with new field: docLevelMonitorPerCategory used for storing the doc level category:monitorId pairs (used when detector is being updated in order to determine which monitors should be deleted and which query indices should be removed).
In order to support multiple detector types, detectorInput has been extended with List detectorTypes property. To keep the possibility of getting all alerts and findings per detector type and per detector id AlertsService and FindingsService has been extended to use the groupedListener and then they are joining/merging the search alert/finding results.
When updating the detector, if one of the doc level monitor has been deleted by deselecting rules, and the whole rule category has been removed, query index will also be deleted.
Here is the document describing the changes from the perspective of client
Issues Resolved
[https://github.com//issues/191]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.