Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix from upstream core.action changes #517

Merged

Conversation

YANG-DB
Copy link
Member

@YANG-DB YANG-DB commented Aug 21, 2023

Description

Fix from upstream core.action changes due to: opensearch-project/OpenSearch#9352

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: YANGDB <yang.db.dev@gmail.com>
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #517 (eec26c4) into main (6d49245) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #517      +/-   ##
============================================
- Coverage     28.20%   28.19%   -0.02%     
+ Complexity      941      940       -1     
============================================
  Files           236      236              
  Lines          9864     9864              
  Branches       1118     1118              
============================================
- Hits           2782     2781       -1     
  Misses         6841     6841              
- Partials        241      242       +1     
Files Changed Coverage Δ
...rch/securityanalytics/SecurityAnalyticsPlugin.java 2.56% <ø> (ø)
...ch/securityanalytics/action/AckAlertsResponse.java 77.27% <ø> (ø)
...ityanalytics/action/CorrelatedFindingResponse.java 0.00% <ø> (ø)
...curityanalytics/action/DeleteDetectorResponse.java 0.00% <ø> (ø)
...h/securityanalytics/action/DeleteRuleResponse.java 0.00% <ø> (ø)
...ch/securityanalytics/action/GetAlertsResponse.java 35.29% <ø> (ø)
...analytics/action/GetAllRuleCategoriesResponse.java 0.00% <ø> (ø)
.../securityanalytics/action/GetDetectorResponse.java 19.44% <ø> (ø)
.../securityanalytics/action/GetFindingsResponse.java 35.29% <ø> (ø)
...rityanalytics/action/GetIndexMappingsResponse.java 35.71% <ø> (ø)
... and 44 more

... and 1 file with indirect coverage changes

@sbcd90 sbcd90 merged commit 8556254 into opensearch-project:main Aug 23, 2023
12 of 15 checks passed
lezzago pushed a commit to lezzago/security-analytics that referenced this pull request Aug 24, 2023
Signed-off-by: YANGDB <yang.db.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants