REST API tests refactoring (Part 4) #4255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willyborankin
requested review from
cliu123,
cwperks,
DarshitChanpura,
peternied,
RyanL1997,
scrawfor99 and
reta
as code owners
willyborankin
force-pushed
the
refactor-tests#4
branch
2 times, most recently
from
2a233bd
to
4d8f22c
Compare
src/integrationTest/java/org/opensearch/security/api/PatchPayloadHelper.java
Show resolved
Hide resolved
src/integrationTest/java/org/opensearch/security/api/ConfigRestApiIntegrationTest.java
Show resolved
Hide resolved
DarshitChanpura
approved these changes
May 6, 2024
cwperks
approved these changes
May 6, 2024
|
@willyborankin Can you rebase this PR? The changes look good to me. |
Moved test: - SecurityConfigApiActionTest into ConfigRestApiIntegrationTest Test with the Legacy prefix removed since new tests use randomization for paths Signed-off-by: Andrey Pleskach <ples@aiven.io>
willyborankin
force-pushed
the
refactor-tests#4
branch
from
4d8f22c
to
4a82b30
Compare
done |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4255 +/- ##
==========================================
- Coverage 66.07% 66.02% -0.05%
==========================================
Files 302 302
Lines 21758 21758
Branches 3522 3522
==========================================
- Hits 14376 14366 -10
- Misses 5614 5623 +9
- Partials 1768 1769 +1 |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-4255-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 faac5e3bfdd55aad69a4bb2cfc8c31c6988d46ea
# Push it to GitHub
git push --set-upstream origin backport/backport-4255-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.xThen, create a pull request where the |
|
@willyborankin would you mind creating a manual backport to 2.x for this? |
willyborankin
added a commit
to willyborankin/security
that referenced
this pull request
May 7, 2024
Signed-off-by: Andrey Pleskach <ples@aiven.io> (cherry picked from commit faac5e3)
This was referenced May 7, 2024
Merged
cwperks
pushed a commit
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved test:
SecurityConfigApiActionTestintoConfigRestApiIntegrationTestTest with the Legacy prefix removed since new tests use randomization for paths
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.