Fix flaky tests #4329
Merged
Fix flaky tests #4329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willyborankin
requested review from
cliu123,
cwperks,
DarshitChanpura,
peternied,
RyanL1997,
scrawfor99 and
reta
as code owners
Signed-off-by: Andrey Pleskach <ples@aiven.io>
willyborankin
force-pushed
the
fix-flaky-tests
branch
from
f9183bc
to
19f28cc
Compare
cwperks
approved these changes
May 7, 2024
reta
approved these changes
May 8, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 8, 2024
Signed-off-by: Andrey Pleskach <ples@aiven.io> (cherry picked from commit bac93dc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed flaky integration tests, which were introduced in #4255. The node counter was defined as a global variable, as result it counted more nodes then an actual local cluster had.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.