Fix compiling error by adding meta fields checker before 7DOT8 in legacy SQL #2701
Conversation
…acy SQL Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG and
ykmr1224
as code owners
|
Could any maintainer help to rerun failed CI? |
|
The original comment for the deleted constant mentions that |
| @@ -41,6 +43,19 @@ public class Util { | |||
|
|
|||
| public static final String NESTED_JOIN_TYPE = "NestedJoinType"; | |||
|
|
|||
| public static final Set<String> META_FIELDS_BEFORE_7DOT8 = | |||
There was a problem hiding this comment.
- Can we wrap this with a static method so we can change implementation easily?
- If we go ahead with this approach, please add comment regarding this is not ideal solution.
- What does the suffix
7D0T8mean?
There was a problem hiding this comment.
7DOT8 is referring to ES 7.8.
"_ttl" and "_timestamp" were removed in ES6. See https://www.elastic.co/blog/elasticsearch-5-0-0-alpha4-released
"_type" was renamed to "_nested_path" in OS 2: opensearch-project/OpenSearch#3196
"_size" is not a built-in metadata mapper, it comes from the mapper-size plugin which is not installed by default. Using mapperService.isMetadataField("_size") should return true if the mapper-size plugin is installed in the cluster.
The other values in this list still exist and are built-in metadata fields so mapperService.isMetadataField() should return true.
| @@ -41,6 +43,19 @@ public class Util { | |||
|
|
|||
| public static final String NESTED_JOIN_TYPE = "NestedJoinType"; | |||
|
|
|||
| public static final Set<String> META_FIELDS_BEFORE_7DOT8 = | |||
| Collections.unmodifiableSet( | |||
There was a problem hiding this comment.
nit: It's simpler to use ImmutableSet.of
|
Revert commit PR is raised and we can be unblocked once that is merged. |
|
Yep, revert PR merged, close this one. |
Description
Fix compiling error by adding meta fields checker before 7DOT8 in legacy SQL
Issues Resolved
#2699
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.