Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Test against opensearch 1.1.x #44

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

phillbaker
Copy link
Collaborator

@phillbaker phillbaker commented May 24, 2023

Description

This pulls in part of the changes from #41.

  • It drops testing support for opendistro on opensearch 7
  • Starts switching to use _plugin routes
  • Updates tests that would have led to permanent diffs

Issues Resolved

Partially address #32

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Phillip Baker <phillbaker@retrodict.com>
@phillbaker
Copy link
Collaborator Author

@prudhvigodithi can you review?

@prudhvigodithi
Copy link
Collaborator

Hey @phillbaker thanks, should this be merged to 1.x branch ? Since main goes with the 2.x series?
Thank you

@phillbaker
Copy link
Collaborator Author

phillbaker commented May 31, 2023

should this be merged to 1.x branch ? Since main goes with the 2.x series?

This is the first step to supporting 2.x, so it belongs on the main branch. Maybe it could be backported to 1.x, but it also has breaking changes as (for example) the endpoints change. I'll open up a following PR for 1.2 and then 1.3 support and work toward 2.x based on PRs by @serge-r.

@prudhvigodithi
Copy link
Collaborator

Thanks @phillbaker approved the PR, once backported we should remove 1.1.0 from the main branch and ensure its only part of the 1.x branch in test.yml file.

@phillbaker phillbaker merged commit cfbbefd into opensearch-project:main Jun 5, 2023
@phillbaker phillbaker deleted the update/1-1 branch June 5, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants