Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that domains resolve #122

Open
stuartpb opened this issue May 25, 2016 · 2 comments
Open

Ensure that domains resolve #122

stuartpb opened this issue May 25, 2016 · 2 comments
Labels
Milestone

Comments

@stuartpb
Copy link
Member

This should be a step further, taken by testing: if the profile's name is not a resolvable domain name with a ".yaml" extension, a mistake has likely been made (like a misspelling), and this would catch that.

@stuartpb
Copy link
Member Author

I'm not sure how often this really happens, though, except when a site dies: I think it'd be better to write a whole tool at some point that runs through the urls listed in a profile and lists what comes back (HTTP status-wise), as well as a test for each filename's root domain.

The purpose of that tool would basically be to see which profiles are most direly need in review: if a lot of 404s and/or redirects are happening, something's probably changed (though, of course, this isn't guaranteed, as some URLs profile a redirecting path, so it can't be used as a test).

@stuartpb
Copy link
Member Author

stuartpb commented Mar 3, 2017

This might make sense as an extended test for pull requests adding new profiles (though see #123 for the current roadblocks around that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant