Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StaffMeasure should be named GraphicalMeasure #264

Closed
bneumann opened this issue May 31, 2018 · 3 comments
Closed

StaffMeasure should be named GraphicalMeasure #264

bneumann opened this issue May 31, 2018 · 3 comments
Assignees
@sschmidTU

Comments

@bneumann
Copy link
Collaborator

See title.
@bneumann bneumann changed the title StaffMeasure should be GraphicalMeasure StaffMeasure should be named GraphicalMeasure May 31, 2018
sschmidTU added a commit that referenced this issue Jul 4, 2018
@sschmidTU
Renamed StaffMeasure to GraphicalMeasure (#264)
a86d7f2 
added package-lock.json to .gitignore
@sschmidTU
Copy link
Contributor

done, see commit.

@bneumann
Copy link
Collaborator Author

bneumann commented Jul 4, 2018

Comment, see comment

@sschmidTU
Copy link
Contributor

@bneumann next time i'll close the issue via commit message, less reference overhead ;)

bneumann added a commit that referenced this issue Jul 4, 2018
@bneumann
fix(Merged develop to be make the PR mergable again): Merged refactor…
aa6e681 
…ing according to #264
ChrisUib pushed a commit that referenced this issue Jul 5, 2018
Added check for undefined curve "if (slur.vfCurve !== undefined) {" i…
b8be65f 
…n VexFlowMusicDrawer.ts. However, most of the slurs are then not shown (it seems that the problems occur for more than one line in the notesheet)

and

Merge branch 'develop' into feature/Slurs

* develop:
  chore(package): update @types/mocha to version 5.2.3 (#279)
  chore(package): update mocha to version 5.2.0 (#281)
  added a few GraphicalMeasure renames not caught by cherry-picked commit, builds again demo working too
  additional StaffMeasure -> GraphicalMeasure renames compiles and demo works again (this time for real)
  Renamed StaffMeasure to GraphicalMeasure (#264) added package-lock.json to .gitignore
  chore(package): update webpack-cli to version 3.0.8 (#277)
  chore: updated travis demo publish script to build the correct demo version (#276)
  chore: updated change log
  chore: bumped version number

# Conflicts:
#	src/MusicalScore/Graphical/VexFlow/VexFlowMusicSheetCalculator.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sschmidTU sschmidTU

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bneumann @sschmidTU