Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(package): update mocha to version 5.2.0 #281

Merged
merged 1 commit into from Jul 4, 2018
Merged

chore(package): update mocha to version 5.2.0 #281

merged 1 commit into from Jul 4, 2018

Conversation

sebastianhaas
Copy link
Member

Closes #192

@sebastianhaas sebastianhaas self-assigned this Jun 26, 2018
@sebastianhaas
Copy link
Member Author

LGTM, @bneumann if you have no objections I'd like to merge this and #279

@bneumann
Copy link
Collaborator

Sure thing

@sebastianhaas sebastianhaas merged commit a280c2c into develop Jul 4, 2018
@sebastianhaas sebastianhaas deleted the greenkeeper/mocha-5.2.0 branch July 4, 2018 12:19
ChrisUib pushed a commit that referenced this pull request Jul 5, 2018
Added check for undefined curve "if (slur.vfCurve !== undefined) {" i…
b8be65f 
…n VexFlowMusicDrawer.ts. However, most of the slurs are then not shown (it seems that the problems occur for more than one line in the notesheet)

and

Merge branch 'develop' into feature/Slurs

* develop:
  chore(package): update @types/mocha to version 5.2.3 (#279)
  chore(package): update mocha to version 5.2.0 (#281)
  added a few GraphicalMeasure renames not caught by cherry-picked commit, builds again demo working too
  additional StaffMeasure -> GraphicalMeasure renames compiles and demo works again (this time for real)
  Renamed StaffMeasure to GraphicalMeasure (#264) added package-lock.json to .gitignore
  chore(package): update webpack-cli to version 3.0.8 (#277)
  chore: updated travis demo publish script to build the correct demo version (#276)
  chore: updated change log
  chore: bumped version number

# Conflicts:
#	src/MusicalScore/Graphical/VexFlow/VexFlowMusicSheetCalculator.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bneumann bneumann Awaiting requested review from bneumann

Assignees

@sebastianhaas sebastianhaas

Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sebastianhaas @bneumann