Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-16297: CIM translations #2449

Merged
merged 3 commits into from
Jan 30, 2024
Merged

MGMT-16297: CIM translations #2449

merged 3 commits into from
Jan 30, 2024

Conversation

jgyselov
Copy link
Collaborator

@jgyselov jgyselov commented Dec 6, 2023 •
edited
Loading

@jgyselov jgyselov requested a review from a team as a code owner December 6, 2023 13:47
@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 6, 2023
@jgyselov jgyselov mentioned this pull request Dec 6, 2023
Closed
@jgyselov jgyselov changed the title CIM translations MGMT-16297: CIM translations Dec 6, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 6, 2023 •
edited by openshift-ci bot
Loading

@jgyselov: This pull request references MGMT-16297 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

stolostron/console#3188

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 6, 2023 •
edited by openshift-ci bot
Loading

@jgyselov: This pull request references MGMT-16297 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/MGMT-16297

stolostron/console#3188

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jgyselov jgyselov force-pushed the cim_translations branch 4 times, most recently from 7d8b780 to 227ec56 Compare December 8, 2023 11:47
rawagner
rawagner previously approved these changes Dec 8, 2023
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2023
ammont82
ammont82 previously approved these changes Dec 15, 2023
View reviewed changes
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2023
@jgyselov jgyselov dismissed stale reviews from ammont82 and rawagner via 9869762 December 19, 2023 09:21
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2023
@jgyselov jgyselov force-pushed the cim_translations branch 2 times, most recently from 45694a0 to 2be0571 Compare December 19, 2023 09:34
@jgyselov jgyselov mentioned this pull request Jan 3, 2024
Merged
@jgyselov jgyselov force-pushed the cim_translations branch 2 times, most recently from 4ca4e4a to 59e35da Compare January 4, 2024 10:31
@jgyselov jgyselov requested a review from rawagner January 4, 2024 12:14
ammont82
ammont82 previously approved these changes Jan 5, 2024
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2024
rawagner
rawagner previously approved these changes Jan 5, 2024
View reviewed changes
@jgyselov jgyselov added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2024
@jgyselov jgyselov dismissed stale reviews from rawagner and ammont82 via cdbcb7c January 29, 2024 10:11
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2024
@jgyselov jgyselov removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, rawagner

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgyselov jgyselov merged commit 2d74cc3 into openshift-assisted:master Jan 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawagner rawagner rawagner approved these changes

@ammont82 ammont82 ammont82 approved these changes

Assignees

@rawagner rawagner

@ammont82 ammont82

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgyselov @openshift-ci-robot @rawagner @ammont82 @openshift-merge-robot