This repository has been archived by the owner on Apr 30, 2023. It is now read-only.
Cluster wizard steps #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtomasek
force-pushed
the
clusterWizardSteps
branch
from
d9f0168
to
04e7435
Compare
flofuchs
previously approved these changes
Feb 14, 2019
honza
added
the
needs-rebase
jtomasek
force-pushed
the
clusterWizardSteps
branch
from
04e7435
to
5ae8502
Compare
jtomasek
removed
the
needs-rebase
Merged
jtomasek
force-pushed
the
clusterWizardSteps
branch
from
5ae8502
to
8412141
Compare
honza
reviewed
Feb 15, 2019
src/components/ClusterWizard.tsx
Outdated
| import CreateClusterForm from './createCluster/CreateClusterForm'; | ||
|
|
||
| const ClusterWizard: FC = (): JSX.Element => ( | ||
| interface ClusterWizardProps { | ||
| currentStepIndex: number; |
There was a problem hiding this comment.
Can we still use a more concrete type to represent the wizard step?
E.g.:
enum WizardStep {
One,
Two
}
let step: WizardStep = WizardStep.One;It gives you much nicer comparisons:
if (step === WizardStep.One) {
}Instead of comparing against numbers.
|
@jtomasek Looking great so far! Hopefully the PatternFly HTML/CSS will land soon to pull from, I'm just noticing small tweaks needed like a bubble behind the numbers... Implementation: |
flofuchs
approved these changes
Feb 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #21