This repository has been archived by the owner on Apr 30, 2023. It is now read-only.
Connect hosts to api #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtomasek
force-pushed
the
connectHostsToAPI
branch
2 times, most recently
from
5a99676
to
5af96ec
Compare
honza
suggested changes
Feb 18, 2019
| @@ -1,3 +1,9 @@ | |||
| export interface Host { | |||
| id: string; | |||
| name: string; | |||
| ip: string; | |||
There was a problem hiding this comment.
The types of the fields of Host should match whatever the server returns.
| </Fragment> | ||
| ); | ||
| interface Props { | ||
| hostRows: string[][]; |
There was a problem hiding this comment.
Let's use a more concrete type here instead of string[][]
src/components/HostsTable.tsx
Outdated
| const HostsTable: FC = (): JSX.Element => { | ||
| const headerStyle = { position: 'sticky', top: 0, background: 'white' }; | ||
| interface Props { | ||
| hostRows: string[][]; |
jtomasek
force-pushed
the
connectHostsToAPI
branch
from
5af96ec
to
39b77db
Compare
flofuchs
previously approved these changes
Feb 18, 2019
added 4 commits
February 18, 2019 13:34
Fix the selectors to be based on RootState, Add getHostTableRows selector and test Remove HostsExample referendes from App.tsx
jtomasek
force-pushed
the
connectHostsToAPI
branch
from
39b77db
to
e4ef00e
Compare
|
Rebased on top of |
flofuchs
approved these changes
Feb 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Populates HostsTable with actual data from API.
Work in progress
Depends on #22