Skip to content
This repository has been archived by the owner on Apr 30, 2023. It is now read-only.

Introduced patternfly empty state for Baremetal inventory #23

Merged
merged 1 commit into from
Feb 22, 2019

Conversation

betherly
Copy link
Contributor

Implemented HostsEmptyState component for Baremetal inventory.
WIP due to need assistance with aligning the EmptyState component
to centre. Styling margin: 0 auto; works, so need to identify
a patternfly component or class that implements that styling.

Copy link
Member

@jtomasek jtomasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using https://prettier.io/ for code formatting. You can apply it either by running yarn prettier or add it to your editor for automatic formatting on save. Doing this will fix most of the linting errors.

You can use <Bullseye> component to align the HostsEmptyState to the center (https://patternfly-react.surge.sh/patternfly-4/layouts/bullseye) See #27. Don't worry about the scrollbar, I am fixing it in #27

src/components/HostsTable.tsx Outdated Show resolved Hide resolved
src/components/HostsTable.tsx Outdated Show resolved Hide resolved
@betherly betherly force-pushed the featureBranch branch 3 times, most recently from d2fc8cb to 717c3e8 Compare February 15, 2019 13:20
Copy link
Member

@jtomasek jtomasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please fix the linting warnings.

src/components/HostsEmptyState.tsx Show resolved Hide resolved
src/components/HostsEmptyState.tsx Outdated Show resolved Hide resolved
@honza
Copy link
Contributor

honza commented Feb 15, 2019

If you rebase your branch on top of master, you'll get a proper build failure here.

@betherly betherly changed the title WIP Introduced patternfly empty state for Baremetal inventory Introduced patternfly empty state for Baremetal inventory Feb 18, 2019
@knowncitizen
Copy link
Contributor

We are using https://prettier.io/ for code formatting. You can apply it either by running yarn prettier or add it to your editor for automatic formatting on save. Doing this will fix most of the linting errors.

You can use <Bullseye> component to align the HostsEmptyState to the center (https://patternfly-react.surge.sh/patternfly-4/layouts/bullseye) See #27. Don't worry about the scrollbar, I am fixing it in #27

Might be worth documenting the prettier stuff in the README, @jtomasek

@knowncitizen
Copy link
Contributor

Nevermind, I did it ;) https://github.com/metalkube/facet/pull/33/files

Copy link
Member

@jtomasek jtomasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there is one wrong import (comment inline)

src/components/HostsTable.tsx Outdated Show resolved Hide resolved
Implemented HostsEmptyState component for Baremetal inventory.
Copy link
Member

@jtomasek jtomasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks!

@betherly betherly merged commit a887742 into openshift-assisted:master Feb 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants