-
Notifications
You must be signed in to change notification settings - Fork 48
Introduced patternfly empty state for Baremetal inventory #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using https://prettier.io/ for code formatting. You can apply it either by running yarn prettier
or add it to your editor for automatic formatting on save. Doing this will fix most of the linting errors.
You can use <Bullseye>
component to align the HostsEmptyState to the center (https://patternfly-react.surge.sh/patternfly-4/layouts/bullseye) See #27. Don't worry about the scrollbar, I am fixing it in #27
d2fc8cb
to
717c3e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Please fix the linting warnings.
If you rebase your branch on top of master, you'll get a proper build failure here. |
717c3e8
to
d1c1fe2
Compare
Might be worth documenting the prettier stuff in the README, @jtomasek |
Nevermind, I did it ;) https://github.com/metalkube/facet/pull/33/files |
d1c1fe2
to
6990920
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, there is one wrong import (comment inline)
Implemented HostsEmptyState component for Baremetal inventory.
6990920
to
dd5a40b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, thanks!
Implemented HostsEmptyState component for Baremetal inventory.
WIP due to need assistance with aligning the EmptyState component
to centre. Styling margin: 0 auto; works, so need to identify
a patternfly component or class that implements that styling.