Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multistage build for prometheus-operator images #23

Merged

Conversation

simonpasquier
Copy link
Contributor

openshift/prometheus-operator has recently switched to use multistage builds for OKD because it had a dependency on Go 1.10 (see openshift/prometheus-operator#14). This is the corresponding change to ensure that the OCP builds keep running. It is based on the actual cluster-monitoring-operator.yml.

cc @s-urbaniak @pgier

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 4, 2018
Copy link

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2018
@adammhaile adammhaile merged commit 026d991 into openshift-eng:master Dec 5, 2018
@simonpasquier simonpasquier deleted the update-prom-operator branch December 5, 2018 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants