Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile files #14

Merged

Conversation

simonpasquier
Copy link

This change uses multistage builds to generate the container images. It also adds the .rhel7 Dockerfile for OCP builds.

This is similar to openshift/cluster-monitoring-operator#147.

cc @s-urbaniak @pgier

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 4, 2018
This change uses multistage builds to generate the container images.
It also adds the .rhel7 Dockerfile for OCP builds.
@pgier
Copy link

pgier commented Dec 4, 2018

/lgtm, @simonpasquier I guess this will fix #13?
Also, after this is merged we'll have to update the Dockerfile setting here: https://github.com/openshift/ocp-build-data/blob/master/openshift-4.0/images/prometheus-operator.yml

Copy link

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

looks great, thanks a lot @simonpasquier !

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2018
@openshift-merge-robot openshift-merge-robot merged commit c4a666f into openshift:master Dec 4, 2018
@simonpasquier simonpasquier deleted the multistage-builds branch December 4, 2018 14:42
@simonpasquier
Copy link
Author

Also, after this is merged we'll have to update the Dockerfile setting here: https://github.com/openshift/ocp-build-data/blob/master/openshift-4.0/images/prometheus-operator.yml

Yep this was my idea too. Will try ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants