Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.2] Prober targets service instead of pods directly (#2112) #250

Merged

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented May 9, 2022

See commit for reference upstream PR

Signed-off-by: Pierangelo Di Pilato pierdipi@redhat.com

@openshift-ci openshift-ci bot requested review from lberk and matzew May 9, 2022 15:47
@openshift-ci openshift-ci bot added the approved label May 9, 2022
@pierDipi
Copy link
Member Author

pierDipi commented May 9, 2022

/test 410-e2e-aws-ocp-410

@pierDipi
Copy link
Member Author

pierDipi commented May 9, 2022

After this one, I'll cherry pick https://github.com/knative-sandbox/eventing-kafka-broker/pull/2164/files

@pierDipi
Copy link
Member Author

/retest

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@pierDipi
Copy link
Member Author

/test 410-reconciler-aws-ocp-410

@pierDipi
Copy link
Member Author

/cherry-pick release-v1.3

@openshift-cherrypick-robot

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-v1.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matzew
Copy link
Member

matzew commented May 10, 2022

/retest

@matzew
Copy link
Member

matzew commented May 10, 2022

@pierDipi perhap we do #249 first?

@pierDipi
Copy link
Member Author

/test 410-reconciler-aws-ocp-410

)

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label May 10, 2022
@matzew
Copy link
Member

matzew commented May 10, 2022

/retest

@aliok
Copy link

aliok commented May 10, 2022

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented May 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [aliok,matzew,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-cherrypick-robot

@pierDipi: new pull request created: #257

In response to this:

/cherry-pick release-v1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants