Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.9] Backport fixes for PingSource client (#7082) #285

Merged
merged 1 commit into from
Jul 27, 2023
Merged

[release-v1.9] Backport fixes for PingSource client (#7082) #285

merged 1 commit into from
Jul 27, 2023

Conversation

pierDipi
Copy link
Member

This cherry-picks the changes for PingSource client in knative@a755429

@pierDipi
Re-enable PingSource TLS E2E test (knative#7082)
327a2a0 
Fixes knative#7021

This is the root cause: cloudevents/sdk-go#923

<!-- Please include the 'why' behind your changes if no issue exists -->

<!-- Please categorize your changes:
- 🎁 Add new feature
- 🐛 Fix bug
- 🧹 Update or clean up current behavior
- 🗑️ Remove feature or internal logic
-->

- Re-enable PingSource TLS E2E test
- Remove hacky client injection for PingSource

<!-- If these boxes are not checked, you will be asked to complete these
requirements or explain why they do not apply to your PR. -->

- [ ] **At least 80% unit test coverage**
- [ ] **E2E tests** for any new behavior
- [ ] **Docs PR** for any user-facing impact
- [ ] **Spec PR** for any new API feature
- [ ] **Conformance test** for any change to the spec

**Release Note**

<!--
📄 If this change has user-visible impact, write a release
note in the block
below. Include the string "action required" if additional action is
required of
users switching to the new release, for example in case of a breaking
change.

Write as if you are speaking to users, not other Knative contributors.
If this
change has no user-visible impact, no release note is needed.
-->

```release-note

```

**Docs**

<!--
📖 If this change has user-visible impact, link to an issue or PR in
https://github.com/knative/docs.
-->

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@openshift-ci openshift-ci bot requested review from aliok and matzew July 25, 2023 10:13
@pierDipi
Copy link
Member Author

/cc @creydr

@openshift-ci openshift-ci bot requested a review from creydr July 27, 2023 09:12
@pierDipi
Copy link
Member Author

/cherry-pick release-v1.10

@openshift-cherrypick-robot
Copy link

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-v1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

creydr
creydr approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6b48d1a into openshift-knative:release-v1.9 Jul 27, 2023
9 checks passed
@openshift-cherrypick-robot
Copy link

@pierDipi: #285 failed to apply on top of branch "release-v1.10":

Applying: Re-enable PingSource TLS E2E test (#7082)
Using index info to reconstruct a base tree...
M	pkg/adapter/v2/cloudevents.go
M	test/e2e-common.sh
Falling back to patching base and 3-way merge...
Auto-merging test/e2e-common.sh
Auto-merging pkg/adapter/v2/cloudevents.go
CONFLICT (content): Merge conflict in pkg/adapter/v2/cloudevents.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Re-enable PingSource TLS E2E test (#7082)
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-v1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi pierDipi deleted the cp-a7554290085a43239b294d1f0f0b77a256630ac5-v1.9 branch July 27, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr creydr approved these changes

@aliok aliok Awaiting requested review from aliok

@matzew matzew Awaiting requested review from matzew

Assignees

@creydr creydr

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
4 participants
@pierDipi @openshift-cherrypick-robot @creydr @openshift-merge-robot