Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.12] [e2e] backport fix ManyTriggers possible starvation of Setup features #587

Open
wants to merge 1 commit into
base: release-v1.12
Choose a base branch
from
Open

[release-v1.12] [e2e] backport fix ManyTriggers possible starvation of Setup features #587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
46 changes: 27 additions & 19 deletions test/rekt/features/broker/feature.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,32 +118,40 @@ func ManyTriggers() *feature.FeatureSet {

for _, testcase := range tests {

testcase := testcase // capture variable
f := feature.NewFeatureNamed(testcase.name)

// Create the broker
brokerName := feature.MakeRandomK8sName("broker")
f.Setup("install broker", broker.Install(brokerName, broker.WithEnvConfig()...))
f.Setup("broker is ready", broker.IsReady(brokerName))
f.Setup("broker is addressable", broker.IsAddressable(brokerName))

for sink, eventFilter := range testcase.eventFilters {
f.Setup("install sink", eventshub.Install(sink, eventshub.StartReceiver))
filter := eventingv1.TriggerFilterAttributes{
"type": eventFilter.Type,
"source": eventFilter.Source,
}

// Point the Trigger subscriber to the sink svc.
cfg := []manifest.CfgFn{
trigger.WithSubscriber(service.AsKReference(sink), ""),
trigger.WithFilter(filter),
trigger.WithExtensions(eventFilter.Extensions),
f.Setup("install broker, sinks and triggers", func(ctx context.Context, t feature.T) {
broker.Install(brokerName, broker.WithEnvConfig()...)(ctx, t)

for sink, eventFilter := range testcase.eventFilters {
eventshub.Install(sink, eventshub.StartReceiver)(ctx, t)

filter := eventingv1.TriggerFilterAttributes{
"type": eventFilter.Type,
"source": eventFilter.Source,
}

// Point the Trigger subscriber to the sink svc.
cfg := []manifest.CfgFn{
trigger.WithSubscriber(service.AsKReference(sink), ""),
trigger.WithFilter(filter),
trigger.WithExtensions(eventFilter.Extensions),
}

trigger.Install(sink, brokerName, cfg...)(ctx, t)
}

// Install the trigger
f.Setup("install trigger", trigger.Install(sink, brokerName, cfg...))
f.Setup("trigger goes ready", trigger.IsReady(sink))
}
broker.IsReady(brokerName)(ctx, t)
broker.IsAddressable(brokerName)(ctx, t)

for sink := range testcase.eventFilters {
trigger.IsReady(sink)(ctx, t)
}
})

for _, event := range testcase.eventsToSend {
eventToSend := cloudevents.NewEvent()
Expand Down