Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor min openshift version validation #213

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Refactor min openshift version validation #213

merged 1 commit into from
Mar 26, 2020

Conversation

aliok
Copy link
Contributor

@aliok aliok commented Mar 25, 2020

Bases #212 PR

Wait until that's merged

@aliok
Copy link
Contributor Author

aliok commented Mar 25, 2020

/hold

Hold until #212 is merged

@aliok aliok mentioned this pull request Mar 25, 2020
Merged
@aliok aliok force-pushed the refactor-min-openshift-version-validation branch from e09cd81 to 748ddf6 Compare March 25, 2020 19:47
@aliok
Copy link
Contributor Author

aliok commented Mar 25, 2020

/retest

2 similar comments
@aliok
Copy link
Contributor Author

aliok commented Mar 26, 2020

/retest

@aliok
Copy link
Contributor Author

aliok commented Mar 26, 2020

/retest

@aliok aliok force-pushed the refactor-min-openshift-version-validation branch from 748ddf6 to ee222ec Compare March 26, 2020 07:25
@aliok
Copy link
Contributor Author

aliok commented Mar 26, 2020

@markusthoemmes still having infra issues.

@aliok
Copy link
Contributor Author

aliok commented Mar 26, 2020

/retest

3 similar comments
@aliok
Copy link
Contributor Author

aliok commented Mar 26, 2020

/retest

@aliok
Copy link
Contributor Author

aliok commented Mar 26, 2020

/retest

@aliok
Copy link
Contributor Author

aliok commented Mar 26, 2020

/retest

@openshift-ci-robot
Copy link

@aliok: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/4.3-gcp-images ee222ec link /test 4.3-gcp-images
ci/prow/4.3-e2e-aws-ocp-43 ee222ec link /test 4.3-e2e-aws-ocp-43

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

markusthoemmes
markusthoemmes approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markusthoemmes markusthoemmes merged commit 31c39d2 into openshift-knative:master Mar 26, 2020
@aliok aliok deleted the refactor-min-openshift-version-validation branch March 26, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusthoemmes markusthoemmes markusthoemmes approved these changes

@jcrossley3 jcrossley3 Awaiting requested review from jcrossley3

Assignees

@markusthoemmes markusthoemmes

Labels
approved do-not-merge/hold lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aliok @openshift-ci-robot @markusthoemmes