Konflux - build all images #2707
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Looks like the Image repositories need to be created manually on quay? |
| build.appstudio.redhat.com/target_branch: '{{target_branch}}' | ||
| pipelinesascode.tekton.dev/max-keep-runs: "3" | ||
| pipelinesascode.tekton.dev/on-cel-expression: event == "pull_request" && target_branch | ||
| == "konflux" && files.all.exists(x, !x.matches('^olm-catalog/|^knative-operator/')) |
There was a problem hiding this comment.
I'm not sure if this condition should be same for all images or different.
There was a problem hiding this comment.
Hmm. I would not do these optiomizations because the operators depend on each other. A simple grep gives me this:
- knative-operator depends on openshift-knative-operator:
e.g. pkg/controller/knativekafka/knativekafka_controller.go: socommon "github.com/openshift-knative/serverless-operator/openshift-knative-operator/pkg/common"
- openshift-knative-operator depends o knative-operator:
pkg/common/deployment.go: "github.com/openshift-knative/serverless-operator/knative-operator/pkg/common"
There was a problem hiding this comment.
Added commit to remove this optimization with explanation in the commit message: f72d433
* knative-operator and openshift-knative-operator depend on each other as they import golang packages from each other * serving/ingress and serving/metadata-webhook don't depend on each other or on operators (and vice versa) but when somebody adds such dependency the build will not be triggered even if it should
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes JIRA #
Proposed Changes
serverless-openshift-knative-operatorand reuse a commonserverless-imagePipeline. All the PipelineRuns re-use the same Pipeline except for Index image that usesserverless-indexPipeline as this is a little different.