-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Konflux pipelines #163
Generate Konflux pipelines #163
Conversation
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
I haven't fully reviewed this but I can see there's just one type of Pipeline. I was working on openshift-knative/serverless-operator#2707 to build all images there and figured there are two Pipelines that are slightly different. I call them |
The serverless-index pipeline is a bit different, because it has additional steps to verify the file based catalog of the index. This was mostly auto generated, as Konflux recognized it as an index build (therefor I needed to reference a devfile, which I reverted, after we had the pipeline generated (openshift-knative/serverless-operator@2a6573d), as this made things more complicated and was not needed anymore (as we had the FBC related tasks in the pipeline)). |
That pipeline will need to be special cased, it's this one basically https://github.com/konflux-ci/build-definitions/tree/main/pipelines/fbc-builder |
One other thing we should keep in mind is to only trigger a pipeline on relevant changes for the component. Otherwise this could trigger endless renovate PRs. See from openshift-knative/serverless-operator#2674
|
But for now, I'm focusing on dependents component, SO will come next |
ACK. Just wanted to mention it in this context, so we don't forget about it |
Let me know if the PR looks ok and code is clean/readable enough as I'd like to try it out for eventing core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only to make sure I understand this correctly: this is the "default-custom" pipeline from Konflux?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it's the new one that is not using PVC for storing artifacts and should solve our issue with PV/PVC Quota
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my side
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d4db16a
into
openshift-knative:main
Follow up to #161