Bump Knative versions to 0.18, where available

[markusthoemmes]

As per title, this bumps various components to 0.18 releases.

Notable exceptions:

• Client
• Kafka Channel/Source

Note: Made it multiple commits for easier review. All commits are signal expect Regenerate files which is just...well...generating files.

[matzew]

@aliok it still seems to fail w/ the pingsource-mt-adapter deployments dispatcher image...

Is that b/c of replicas: 0

serverless-operator/openshift-knative-operator/cmd/operator/kodata/knative-eventing/0.18.4/2-eventing-core.yaml

Line 671 in c9537e1

replicas: 0

OR, is the suggested syntax not correct:

image "pingsource-mt-adapter__dispatcher"                  "${eventing}-mtping"

But... this looks good... to me..... 🤔

serverless-operator/olm-catalog/serverless-operator/manifests/serverless-operator.clusterserviceversion.yaml

Lines 337 to 338 in c9537e1

	- name: "IMAGE_pingsource-mt-adapter__dispatcher"
	value: "registry.svc.ci.openshift.org/openshift/knative-v0.18.4:knative-eventing-mtping"

[markusthoemmes]

@matzew where's that failing? The operator test is still running. The current failure is in the upgrade suite.

[aliok]

I will try locally. Please bear with me

[matzew]

@markusthoemmes ah...
I clicked the link on the fail - it had the OLD details link available in there 🤦

[aliok]

/test 4.6-upgrade-tests-aws-ocp-46

Just wanna see if the upgrade test failure persists

[markusthoemmes]

/test 4.6-upstream-e2e-aws-ocp-46

Prolly flake.

[markusthoemmes]

I reproduced the long running/hanging operator test locally. The serving webhook has trouble coming up again. Eventing will likely behave the same. Gonna work on that tomorrow.

[markusthoemmes]

/retest

[markusthoemmes]

/retest

Infra.

[markusthoemmes]

/retest

[markusthoemmes]

/test 4.6-upgrade-tests-aws-ocp-46

[cardil]

/test 4.6-upgrade-tests-aws-ocp-46

We need additional PRs targeting openshift/knative-eventing (missing Dockerfile), and openshift/release (image mirroring)

[cardil]

openshift/knative-eventing#985 needs to be merged, and after openshift/release#13751 is merged images will sync every hour. After that we can retrigger tests.

[matzew]

/retest

[cardil]

Error is:

Failed to pull image "quay.io/openshift-knative/wathola-fetcher:v0.18.4": rpc error: code = Unknown desc = Error reading manifest v0.18.4 in quay.io/openshift-knative/wathola-fetcher: manifest unknown: manifest unknown

There are no v0.18.4 images yet: https://quay.io/repository/openshift-knative/wathola-fetcher?tag=v0.18.4&tab=tags

[markusthoemmes]

/retest

[rhuss]

Looks good to me, but it would be helpful (possibly for everyone interested in the update mechanics), why you e.g. need to change the kourier deployment (guess because of ServiceMesh 2.0 ?) and why the liveness/readiness check needs to be patched in.

[markusthoemmes]

Looks good to me, but it would be helpful (possibly for everyone interested in the update mechanics), why you e.g. need to change the kourier deployment (guess because of ServiceMesh 2.0 ?) and why the liveness/readiness check needs to be patched in.

Kourier just comes in via the new version number. The changes are pulled from upstream automatically via our make generated-files. Same update as the Serving/Eventing manifests really.

The liveness patch is a bugfix (I meanwhile backported upstream). In a nutshell: The old liveness config is not lenient enough. Because of leader election shenanigans, the webhook can be in an infinite crashloopbackoff because the liveness probe kills it before it has a chance to become the leader. There are several bugfixes around stuff like that at HEAD upstream to make it even better, but I really don't want to be backporting K8s deps and stuff like that.

[openshift-merge-robot]

@markusthoemmes: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/4.6-upstream-e2e-aws-ocp-46	252f251	link	/test 4.6-upstream-e2e-aws-ocp-46

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[markusthoemmes]

/test 4.6-upstream-e2e-aws-ocp-46

[rhuss]

thanks !

/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [markusthoemmes,rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment