Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating CI config for Knative Eventing release-v0.18.4 #13764

Merged

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Nov 19, 2020

As title says.

@cardil
Copy link
Contributor Author

cardil commented Nov 19, 2020

This is required for #13751 to be able to sync

@matzew
Copy link
Member

matzew commented Nov 19, 2020

/hold

use the modified script from this PR @cardil
openshift/knative-eventing#988

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2020
@cardil
Copy link
Contributor Author

cardil commented Nov 19, 2020

Now, it looks much better

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2020
@cardil
Copy link
Contributor Author

cardil commented Nov 19, 2020

It's required for openshift-knative/serverless-operator#697

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 19, 2020

@cardil: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/periodic-ci-openshift-knative-eventing-release-v0.18.4-46-e2e-aws-ocp-46-continuous cc55ea5 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cardil
Copy link
Contributor Author

cardil commented Nov 19, 2020

Test was failing due to openshift/knative-eventing#985

Now, it's merged we can do a:

/retest

@matzew
Copy link
Member

matzew commented Nov 20, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2020
@openshift-merge-robot openshift-merge-robot merged commit d4beb4f into openshift:master Nov 20, 2020
@openshift-ci-robot
Copy link
Contributor

@cardil: Updated the ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-knative-eventing-release-v0.18.4__46.yaml using file ci-operator/config/openshift/knative-eventing/openshift-knative-eventing-release-v0.18.4__46.yaml

In response to this:

As title says.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cardil cardil deleted the bugfix/knative-0.18-ci-update branch November 20, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
4 participants