ztp: OCPBUGS-28651: ptp WPC dual card set 2nd card ts2phc.master to 0 #1807
Conversation
jzding
force-pushed
the
2cards
branch
2 times, most recently
from
65e6b96
to
f4c9df8
Compare
jzding
changed the title
openshift-ci-robot
added
jira/severity-moderate
|
@jzding: This pull request references Jira Issue OCPBUGS-28651, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@jzding: This pull request references Jira Issue OCPBUGS-28651, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (hhassid@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
@Bonnie-Block: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jzding: This pull request references Jira Issue OCPBUGS-28651, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (hhassid@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
@yliu127: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/assign sakhoury |
|
/test ztp-ci |
|
/approve cancel |
openshift-ci
bot
removed
the
approved
|
@jzding the following ztp test failed: |
|
/test ztp-ci |
1 similar comment
|
/test ztp-ci |
|
/retest |
|
/retest |
|
/cherry-pick release-4.15 |
|
@jzding: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Under ts2phcConf the second card should have `ts2phc.master 0` to indicate it gets its source from PPS instead of GPS. Rename the 2nd card and added more ports to be consistent with the namings of single card config. Signed-off-by: Jack Ding <jackding@gmail.com>
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aneeshkp, josephdrichard, jzding, sakhoury The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@jzding: Jira Issue OCPBUGS-28651: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-28651 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jzding: new pull request created: #1816 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Under ts2phcConf the second card should have
ts2phc.master 0to indicate it gets its source from PPS instead of GPS.Rename the 2nd card and added more ports to be consistent with the namings of single card config.