Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] ztp: OCPBUGS-29241: ptp WPC dual card set 2nd card ts2phc.master to 0 #1816

Merged
merged 1 commit into from Feb 14, 2024
Merged

[release-4.15] ztp: OCPBUGS-29241: ptp WPC dual card set 2nd card ts2phc.master to 0 #1816

merged 1 commit into from Feb 14, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1807

/assign jzding

@jzding
ztp: ptp WPC dual card set 2nd card ts2phc.master to 0
4c9f7cd 
Under ts2phcConf the second card should have `ts2phc.master 0`
to indicate it gets its source from PPS instead of GPS.

Rename the 2nd card and added more ports to be consistent with
the namings of single card config.

Signed-off-by: Jack Ding <jackding@gmail.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 8, 2024
Merged
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: Jira Issue OCPBUGS-28651 has been cloned as Jira Issue OCPBUGS-29241. Will retitle bug to link to clone.
/retitle [release-4.15] ztp: OCPBUGS-29241: ptp WPC dual card set 2nd card ts2phc.master to 0

In response to this:

This is an automated cherry-pick of #1807

/assign jzding

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] ztp: OCPBUGS-28651: ptp WPC dual card set 2nd card ts2phc.master to 0 [release-4.15] ztp: OCPBUGS-29241: ptp WPC dual card set 2nd card ts2phc.master to 0 Feb 8, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Feb 8, 2024
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-29241, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-28651 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-28651 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @yliu127

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1807

/assign jzding

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 8, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 8, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yliu127.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-29241, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-28651 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-28651 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @yliu127

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1807

/assign jzding

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jzding
jzding approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@jzding jzding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jzding, openshift-cherrypick-robot, sakhoury

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e674b14 into openshift-kni:release-4.15 Feb 14, 2024
4 checks passed
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: Jira Issue OCPBUGS-29241: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29241 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #1807

/assign jzding

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakhoury sakhoury sakhoury approved these changes

@jzding jzding jzding approved these changes

@Missxiaoguo Missxiaoguo Awaiting requested review from Missxiaoguo

@yanirq yanirq Awaiting requested review from yanirq

Assignees

@sakhoury sakhoury

@jzding jzding

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@openshift-cherrypick-robot @openshift-ci-robot @sakhoury @jzding