AGENT-337: When using ZTP manifests, support both VIP and VIPs #1604
Conversation
In agent_cluster_install.yaml, include VIPS in addition to VIP to be compatible with the assisted-service change. openshift/assisted-service#5501
|
/cc @andfasano |
|
@nmagnezi: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
@zaneb can you please approve? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano, filanov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit f7799f0
into
openshift-metal3:master
|
@filanov was this blocking something? |
|
in the latest version we removed api vip and ingress vip and replaced with api vips and ingress vips |
|
I don't believe this fixed a blocking issue, Nir and I had verified that the singular work still worked with agent-cluster-install.yaml. It just is consistent now with the API. Also multiple VIPs are now supported in agent dev-scripts ZTP testing, this was an earlier oversight. |
@filanov we don't remove fields from a kube API, you can only create a new version of the API without that field. But I believe that Nir and Bob have it under control. |
|
Yes we are adding a new api version, v1beta2 |
|
@carbonin is taking over that work from Nir |
In agent_cluster_install.yaml, include VIPS in addition to VIP to be compatible with the assisted-service change.
openshift/assisted-service#5501