MGMT-14810: Remove API and Ingress VIP #5501
Conversation
|
@nmagnezi: This pull request references MGMT-14810 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/test ? |
openshift-ci
bot
added
the
size/XXL
|
@nmagnezi: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test edge-lint |
openshift-ci
bot
added
api-review
nmagnezi
force-pushed
the
MGMT-14810_remove_api_ingress_vip
branch
from
45f877a
to
9d34158
Compare
|
/test edge-lint |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5501 +/- ##
==========================================
+ Coverage 67.94% 67.99% +0.05%
==========================================
Files 233 233
Lines 34395 34324 -71
==========================================
- Hits 23368 23340 -28
+ Misses 8953 8916 -37
+ Partials 2074 2068 -6
|
nmagnezi
force-pushed
the
MGMT-14810_remove_api_ingress_vip
branch
from
9d34158
to
c2d3063
Compare
|
/test edge-lint |
nmagnezi
force-pushed
the
MGMT-14810_remove_api_ingress_vip
branch
2 times, most recently
from
e828b4c
to
d8f4d23
Compare
|
/test edge-lint |
nmagnezi
force-pushed
the
MGMT-14810_remove_api_ingress_vip
branch
from
d8f4d23
to
e3627e4
Compare
|
/test edge-lint |
|
/test edge-subsystem-aws |
nmagnezi
force-pushed
the
MGMT-14810_remove_api_ingress_vip
branch
from
e3627e4
to
21c8a75
Compare
|
/test edge-lint |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
nmagnezi
changed the title
|
/retest |
|
/retest-required |
nmagnezi
force-pushed
the
MGMT-14810_remove_api_ingress_vip
branch
from
5d0d840
to
3d4916c
Compare
nmagnezi
force-pushed
the
MGMT-14810_remove_api_ingress_vip
branch
from
3d4916c
to
df11abb
Compare
|
/retest-required |
1 similar comment
|
/retest-required |
|
/test edge-e2e-ai-operator-ztp-3masters |
|
/retest-required |
|
/test edge-e2e-metal-assisted-mce |
|
/test edge-e2e-vsphere-assisted |
|
/test edge-e2e-ai-operator-ztp-capi |
|
/test edge-e2e-oci-assisted-4-14 |
|
/test edge-e2e-nutanix-assisted |
|
/test edge-e2e-nutanix-assisted-4-14 |
|
/test edge-e2e-oci-assisted |
|
/override ci/prow/edge-e2e-nutanix-assisted-4-14 |
|
@nmagnezi: Overrode contexts on behalf of nmagnezi: ci/prow/edge-e2e-nutanix-assisted-4-14 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/edge-e2e-nutanix-assisted |
|
/override ci/prow/edge-e2e-ai-operator-ztp-disconnected |
|
@nmagnezi: Overrode contexts on behalf of nmagnezi: ci/prow/edge-e2e-nutanix-assisted In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@nmagnezi: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@nmagnezi: Overrode contexts on behalf of nmagnezi: ci/prow/edge-e2e-ai-operator-ztp-disconnected In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avishayt, nmagnezi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-agent-installer-api-server-container-v4.15.0-202311260850.p0.g85498bc.assembly.stream for distgit ose-agent-installer-api-server. |
The assisted-service is deprecating support for the singular APIVIP/IngressVIP in openshift/assisted-service#5501. When that merges it will break the agent-installer since currently APIVIP is set when only one VIP is configured. This change sets both API/Ingress VIP and VIPs and will work before and after the assisted-service change merges. Note that as a follow-on, openshift#7574 will remove the multiple settings from install-config override which are not needed after the assisted-service change.
In agent_cluster_install.yaml, include VIPS in addition to VIP to be compatible with the assisted-service change. openshift/assisted-service#5501
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist