Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPQE-19493: Update image with equinix.cloud collection #1633

Merged
merged 1 commit into from
Apr 2, 2024
Merged

OCPQE-19493: Update image with equinix.cloud collection #1633

merged 1 commit into from
Apr 2, 2024

Conversation

sgoveas
Copy link
Contributor

@sgoveas sgoveas commented Feb 19, 2024

'facility' was deprecated from Dec 1, 2023. This PR update is to use equinix.cloud ansible
collection to enable use of 'metro'.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 19, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 19, 2024

Hi @sgoveas. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sgoveas sgoveas mentioned this pull request Feb 19, 2024
Merged
@derekhiggins
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2024
@sgoveas
Copy link
Contributor Author

sgoveas commented Feb 20, 2024

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 20, 2024

@sgoveas: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@derekhiggins
Copy link
Collaborator

/retest-required

@derekhiggins
Copy link
Collaborator

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@sgoveas
Copy link
Contributor Author

sgoveas commented Mar 12, 2024

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 12, 2024

@sgoveas: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@derekhiggins
Copy link
Collaborator

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2024
@derekhiggins
Copy link
Collaborator

/test e2e-metal-ipi-serial-ipv4

@derekhiggins
Copy link
Collaborator

/test e2e-metal-ipi-serial-ipv4
test failed but still pending?

@LiangquanLi930
Copy link
Contributor

/test e2e-metal-ipi-serial-ipv4

1 similar comment
@adriengentil
Copy link
Contributor

/test e2e-metal-ipi-serial-ipv4

@adriengentil
Copy link
Contributor

adriengentil commented Mar 21, 2024 •
edited
Loading

Our CI on assisted is broken since openshift/release#48680 was merged. I think we need this change to be merged to fix the issue.

@aleskandro
Copy link
Contributor

/test e2e-metal-ipi-serial-ipv4

@sgoveas sgoveas mentioned this pull request Mar 21, 2024
Merged
@derekhiggins
Copy link
Collaborator

/override e2e-metal-ipi-serial-ipv4

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 21, 2024

@derekhiggins: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-metal-ipi-serial-ipv4

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-agent-compact-ipv4
  • ci/prow/e2e-agent-ha-dualstack
  • ci/prow/e2e-agent-sno-ipv6
  • ci/prow/e2e-metal-ipi-bm
  • ci/prow/e2e-metal-ipi-bm-bond
  • ci/prow/e2e-metal-ipi-ovn-dualstack
  • ci/prow/e2e-metal-ipi-ovn-ipv6
  • ci/prow/e2e-metal-ipi-serial-ipv4
  • ci/prow/e2e-metal-ipi-serial-ovn-ipv6
  • ci/prow/e2e-metal-ipi-virtualmedia
  • ci/prow/images
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-compact-ipv4
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-ha-dualstack
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-sno-ipv6
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-metal-ipi-bm
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-metal-ipi-bm-bond
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-metal-ipi-ovn-dualstack
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-metal-ipi-serial-ipv4
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-metal-ipi-serial-ovn-ipv6
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-metal-ipi-virtualmedia
  • pull-ci-openshift-metal3-dev-scripts-master-images
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override e2e-metal-ipi-serial-ipv4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@derekhiggins
Copy link
Collaborator

/override ci/prow/e2e-metal-ipi-serial-ipv4

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 21, 2024

@derekhiggins: Overrode contexts on behalf of derekhiggins: ci/prow/e2e-metal-ipi-serial-ipv4

In response to this:

/override ci/prow/e2e-metal-ipi-serial-ipv4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@derekhiggins
Copy link
Collaborator

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2024
@sgoveas
OCPQE-19493: Update image with equinix.cloud collection
23f26f7 
'facility' was deprecated from Dec 1, 2023. This PR update is to use
[equinix.cloud ansible
collection](https://deploy.equinix.com/labs/ansible-collection-equinix/)
to enable use of 'metro'.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
@derekhiggins
Copy link
Collaborator

/lgtm
unhold when ever you are ready

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
@sgoveas
Copy link
Contributor Author

sgoveas commented Mar 22, 2024

/test e2e-metal-ipi-serial-ipv4

1 similar comment
@sgoveas
Copy link
Contributor Author

sgoveas commented Mar 22, 2024

/test e2e-metal-ipi-serial-ipv4

@sgoveas
Copy link
Contributor Author

sgoveas commented Mar 28, 2024

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 28, 2024 •
edited
Loading

@sgoveas: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-virtualmedia 23f26f7 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-bm-bond 23f26f7 link false /test e2e-metal-ipi-bm-bond
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 23f26f7 link false /test e2e-metal-ipi-serial-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@eifrach eifrach mentioned this pull request Apr 2, 2024
Closed
@derekhiggins
Copy link
Collaborator

/override ci/prow/e2e-metal-ipi-serial-ipv4

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 2, 2024

@derekhiggins: Overrode contexts on behalf of derekhiggins: ci/prow/e2e-metal-ipi-serial-ipv4

In response to this:

/override ci/prow/e2e-metal-ipi-serial-ipv4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sgoveas
Copy link
Contributor Author

sgoveas commented Apr 2, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a19f80f into openshift-metal3:master Apr 2, 2024
9 of 12 checks passed
@sgoveas sgoveas deleted the equinix_cloud branch April 3, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekhiggins derekhiggins Awaiting requested review from derekhiggins

@zaneb zaneb Awaiting requested review from zaneb

Assignees

@derekhiggins derekhiggins

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sgoveas @derekhiggins @LiangquanLi930 @adriengentil @aleskandro