Always mirror with --keep-manifest-list=true #1648
Conversation
The code to conditionaly add --keep-manifest-list=true to the mirror command was added for a now unsupported version of OC. Remove it as it doesn't always work e.g. if the .releaseClientVersion doesn't follow the 4.XX... format. 4.15.0-0.nightly-2024-..-..... vs 0.0.1-0.test-2024-....-latest
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
ci/prow/e2e-metal-ipi-serial-ipv4 |
|
/test e2e-metal-ipi-serial-ipv4 |
2 similar comments
|
/test e2e-metal-ipi-serial-ipv4 |
|
/test e2e-metal-ipi-serial-ipv4 |
|
/test e2e-metal-ipi-serial-ipv4 |
|
/test e2e-metal-ipi-serial-ipv4 |
|
/test images |
|
/test e2e-metal-ipi-bm |
|
/test e2e-metal-ipi-bm |
|
@derekhiggins: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test e2e-metal-ipi-bm |
openshift-merge-bot
bot
merged commit d7ce3f4
into
openshift-metal3:master
The code to conditionaly add --keep-manifest-list=true to the mirror command was added for a now unsupported version of OC. Remove it as it doesn't always work e.g. if the .releaseClientVersion doesn't follow the 4.XX... format.
4.15.0-0.nightly-2024-..-.....
vs
0.0.1-0.test-2024-....-latest