Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always mirror with --keep-manifest-list=true #1648

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

derekhiggins
Copy link
Collaborator

The code to conditionaly add --keep-manifest-list=true to the mirror command was added for a now unsupported version of OC. Remove it as it doesn't always work e.g. if the .releaseClientVersion doesn't follow the 4.XX... format.

4.15.0-0.nightly-2024-..-.....
vs
0.0.1-0.test-2024-....-latest

The code to conditionaly add --keep-manifest-list=true to
the mirror command was added for a now unsupported version
of OC. Remove it as it doesn't always work e.g. if the
.releaseClientVersion doesn't follow the 4.XX... format.

4.15.0-0.nightly-2024-..-.....
vs
0.0.1-0.test-2024-....-latest
@openshift-ci openshift-ci bot requested review from sadasu and zaneb April 4, 2024 10:09
Copy link

openshift-ci bot commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from derekhiggins. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Apr 4, 2024

@derekhiggins: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-ha-dualstack 7203534 link false /test e2e-agent-ha-dualstack
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 7203534 link false /test e2e-metal-ipi-serial-ovn-ipv6
ci/prow/e2e-metal-ipi-serial-ipv4 7203534 link true /test e2e-metal-ipi-serial-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfosardo
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants