This repository has been archived by the owner on Jul 23, 2019. It is now read-only.
baremetal: Drop early exit during create. #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is no longer necessary. See: openshift-metal3/dev-scripts#652 Closes openshift-metal3#60
|
See openshift-metal3/dev-scripts#652, which changes dev-scripts to no longer perform any actions after the early exit, showing that this safe to merge |
|
@stbenjam FYI - a good one to include before the next installer PR update |
|
We should be able to run CI on this, even without the dev-scripts changes. We'll see the cluster come up on the |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/838/ |
|
Works fine for me, looks like CI failure is unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is no longer necessary. See: openshift-metal3/dev-scripts#652
Closes #60