Add baremetal IPI platform #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
markmc
reviewed
Jun 19, 2019
russellb
reviewed
Jun 19, 2019
russellb
reviewed
Jun 19, 2019
|
Builds for other platforms will fail until openshift-metal3/kni-installer#115 is in, go-lint is addressed in openshift-metal3/kni-installer#113. |
|
Please reduce the bash and python magic, and make sure there is a lot of documentation. It's not acceptable to point to docs in a different repo, I would expect that commits have the detailed documentation. |
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
stbenjam
force-pushed
the
baremetal-ipi
branch
2 times, most recently
from
ec082ae
to
e4d82ab
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, eparis, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tomassedovic
pushed a commit
to tomassedovic/openshift-installer
that referenced
this pull request
Jul 17, 2019
For platforms without a DNS as a Service available, there is a chicken/egg scenario. This is because we cannot setup our own DNS solution on the nodes before they are booted via ignition. Instead, we get the ignition config via a virtual IP that is conifgured and maintained by keepalived. The setup of keepalived will be done via machine-config-operator, so it is not part of this patch. This patch only sets up the plumbing so that we can merge the keepalived work while keeping CI green. Then we can put up a patch that will switch to actually using this functionality. This patch also adds an interface for other platforms that need this functionality to work from. Specifically, these PRs can be rebased on this work: openshift#1873 openshift#1948
|
/retest |
trown
pushed a commit
to trown/installer
that referenced
this pull request
Jul 17, 2019
For platforms without a DNS as a Service available, there is a chicken/egg scenario. This is because we cannot setup our own DNS solution on the nodes before they are booted via ignition. Instead, we get the ignition config via a virtual IP that is conifgured and maintained by keepalived. The setup of keepalived will be done via machine-config-operator, so it is not part of this patch. This patch only sets up the plumbing so that we can merge the keepalived work while keeping CI green. Then we can put up a patch that will switch to actually using this functionality. This patch also adds an interface for other platforms that need this functionality to work from. Specifically, these PRs can be rebased on this work: openshift#1873 openshift#1948
|
@stbenjam: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
trown
pushed a commit
to trown/installer
that referenced
this pull request
Jul 18, 2019
For platforms without a DNS as a Service available, there is a chicken/egg scenario. This is because we cannot setup our own DNS solution on the nodes before they are booted via ignition. Instead, we get the ignition config via a virtual IP that is conifgured and maintained by keepalived. The setup of keepalived will be done via machine-config-operator, so it is not part of this patch. This patch only sets up the plumbing so that we can merge the keepalived work while keeping CI green. Then we can put up a patch that will switch to actually using this functionality. This patch also adds an interface for other platforms that need this functionality to work from. Specifically, these PRs can be rebased on this work: openshift#1873 openshift#1948
trown
pushed a commit
to trown/installer
that referenced
this pull request
Jul 18, 2019
For platforms without a DNS as a Service available, there is a chicken/egg scenario. This is because we cannot setup our own DNS solution on the nodes before they are booted via ignition. Instead, we get the ignition config via a virtual IP that is conifgured and maintained by keepalived. The setup of keepalived will be done via machine-config-operator, so it is not part of this patch. This patch only sets up the plumbing so that we can merge the keepalived work while keeping CI green. Then we can put up a patch that will switch to actually using this functionality. This patch also adds an interface for other platforms that need this functionality to work from. Specifically, these PRs can be rebased on this work: openshift#1873 openshift#1948
trown
pushed a commit
to trown/installer
that referenced
this pull request
Jul 18, 2019
For platforms without a DNS as a Service available, there is a chicken/egg scenario. This is because we cannot setup our own DNS solution on the nodes before they are booted via ignition. Instead, we get the ignition config via a virtual IP that is conifgured and maintained by keepalived. The setup of keepalived will be done via machine-config-operator, so it is not part of this patch. This patch only sets up the plumbing so that we can merge the keepalived work while keeping CI green. Then we can put up a patch that will switch to actually using this functionality. This patch also adds an interface for other platforms that need this functionality to work from. Specifically, these PRs can be rebased on this work: openshift#1873 openshift#1948
trown
pushed a commit
to trown/installer
that referenced
this pull request
Jul 18, 2019
For platforms without a DNS as a Service available, there is a chicken/egg scenario. This is because we cannot setup our own DNS solution on the nodes before they are booted via ignition. Instead, we get the ignition config via a virtual IP that is conifgured and maintained by keepalived. The setup of keepalived will be done via machine-config-operator, so it is not part of this patch. This patch only sets up the plumbing so that we can merge the keepalived work while keeping CI green. Then we can put up a patch that will switch to actually using this functionality. This patch also adds an interface for other platforms that need this functionality to work from. Specifically, these PRs can be rebased on this work: openshift#1873 openshift#1948
trown
pushed a commit
to trown/installer
that referenced
this pull request
Jul 18, 2019
For platforms without a DNS as a Service available, there is a chicken/egg scenario. This is because we cannot setup our own DNS solution on the nodes before they are booted via ignition. Instead, we get the ignition config via a virtual IP that is conifgured and maintained by keepalived. The setup of keepalived will be done via machine-config-operator, so it is not part of this patch. This patch only sets up the plumbing so that we can merge the keepalived work while keeping CI green. Then we can put up a patch that will switch to actually using this functionality. This patch also adds an interface for other platforms that need this functionality to work from. Specifically, these PRs can be rebased on this work: openshift#1873 openshift#1948
tomassedovic
pushed a commit
to tomassedovic/openshift-installer
that referenced
this pull request
Jul 18, 2019
For platforms without a DNS as a Service available, there is a chicken/egg scenario. This is because we cannot setup our own DNS solution on the nodes before they are booted via ignition. Instead, we get the ignition config via a virtual IP that is conifgured and maintained by keepalived. The setup of keepalived will be done via machine-config-operator, so it is not part of this patch. This patch only sets up the plumbing so that we can merge the keepalived work while keeping CI green. Then we can put up a patch that will switch to actually using this functionality. This patch also adds an interface for other platforms that need this functionality to work from. Specifically, these PRs can be rebased on this work: openshift#1873 openshift#1948
tomassedovic
pushed a commit
to tomassedovic/openshift-installer
that referenced
this pull request
Jul 24, 2019
For platforms without a DNS as a Service available, there is a chicken/egg scenario. This is because we cannot setup our own DNS solution on the nodes before they are booted via ignition. Instead, we get the ignition config via a virtual IP that is conifgured and maintained by keepalived. The setup of keepalived will be done via machine-config-operator, so it is not part of this patch. This patch only sets up the plumbing so that we can merge the keepalived work while keeping CI green. Then we can put up a patch that will switch to actually using this functionality. This patch also adds an interface for other platforms that need this functionality to work from. Specifically, these PRs can be rebased on this work: openshift#1873 openshift#1948
iamemilio
pushed a commit
to iamemilio/installer
that referenced
this pull request
Jul 26, 2019
For platforms without a DNS as a Service available, there is a chicken/egg scenario. This is because we cannot setup our own DNS solution on the nodes before they are booted via ignition. Instead, we get the ignition config via a virtual IP that is conifgured and maintained by keepalived. The setup of keepalived will be done via machine-config-operator, so it is not part of this patch. This patch only sets up the plumbing so that we can merge the keepalived work while keeping CI green. Then we can put up a patch that will switch to actually using this functionality. This patch also adds an interface for other platforms that need this functionality to work from. Specifically, these PRs can be rebased on this work: openshift#1873 openshift#1948
mandre
pushed a commit
to mandre/installer
that referenced
this pull request
Jul 26, 2019
For platforms without a DNS as a Service available, there is a chicken/egg scenario. This is because we cannot setup our own DNS solution on the nodes before they are booted via ignition. Instead, we get the ignition config via a virtual IP that is conifgured and maintained by keepalived. The setup of keepalived will be done via machine-config-operator, so it is not part of this patch. This patch only sets up the plumbing so that we can merge the keepalived work while keeping CI green. Then we can put up a patch that will switch to actually using this functionality. This patch also adds an interface for other platforms that need this functionality to work from. Specifically, these PRs can be rebased on this work: openshift#1873 openshift#1948
tomassedovic
pushed a commit
to tomassedovic/openshift-installer
that referenced
this pull request
Jul 26, 2019
For platforms without a DNS as a Service available, there is a chicken/egg scenario. This is because we cannot setup our own DNS solution on the nodes before they are booted via ignition. Instead, we get the ignition config via a virtual IP that is conifgured and maintained by keepalived. The setup of keepalived will be done via machine-config-operator, so it is not part of this patch. This patch only sets up the plumbing so that we can merge the keepalived work while keeping CI green. Then we can put up a patch that will switch to actually using this functionality. This patch also adds an interface for other platforms that need this functionality to work from. Specifically, these PRs can be rebased on this work: openshift#1873 openshift#1948
iamemilio
pushed a commit
to iamemilio/installer
that referenced
this pull request
Jul 26, 2019
For platforms without a DNS as a Service available, there is a chicken/egg scenario. This is because we cannot setup our own DNS solution on the nodes before they are booted via ignition. Instead, we get the ignition config via a virtual IP that is conifgured and maintained by keepalived. The setup of keepalived will be done via machine-config-operator, so it is not part of this patch. This patch only sets up the plumbing so that we can merge the keepalived work while keeping CI green. Then we can put up a patch that will switch to actually using this functionality. This patch also adds an interface for other platforms that need this functionality to work from. Specifically, these PRs can be rebased on this work: openshift#1873 openshift#1948
tomassedovic
pushed a commit
to tomassedovic/openshift-installer
that referenced
this pull request
Jul 30, 2019
For platforms without a DNS as a Service available, there is a chicken/egg scenario. This is because we cannot setup our own DNS solution on the nodes before they are booted via ignition. Instead, we get the ignition config via a virtual IP that is conifgured and maintained by keepalived. The setup of keepalived will be done via machine-config-operator, so it is not part of this patch. This patch only sets up the plumbing so that we can merge the keepalived work while keeping CI green. Then we can put up a patch that will switch to actually using this functionality. This patch also adds an interface for other platforms that need this functionality to work from. Specifically, these PRs can be rebased on this work: openshift#1873 openshift#1948
tomassedovic
pushed a commit
to tomassedovic/openshift-installer
that referenced
this pull request
Jul 31, 2019
For platforms without a DNS as a Service available, there is a chicken/egg scenario. This is because we cannot setup our own DNS solution on the nodes before they are booted via ignition. Instead, we get the ignition config via a virtual IP that is conifgured and maintained by keepalived. The setup of keepalived will be done via machine-config-operator, so it is not part of this patch. This patch only sets up the plumbing so that we can merge the keepalived work while keeping CI green. Then we can put up a patch that will switch to actually using this functionality. This patch also adds an interface for other platforms that need this functionality to work from. Specifically, these PRs can be rebased on this work: openshift#1873 openshift#1948
mandre
pushed a commit
to mandre/installer
that referenced
this pull request
Aug 5, 2019
For platforms without a DNS as a Service available, there is a chicken/egg scenario. This is because we cannot setup our own DNS solution on the nodes before they are booted via ignition. Instead, we get the ignition config via a virtual IP that is conifgured and maintained by keepalived. The setup of keepalived will be done via machine-config-operator, so it is not part of this patch. This patch only sets up the plumbing so that we can merge the keepalived work while keeping CI green. Then we can put up a patch that will switch to actually using this functionality. This patch also adds an interface for other platforms that need this functionality to work from. Specifically, these PRs can be rebased on this work: openshift#1873 openshift#1948
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Sep 5, 2019
Most of our docs were bumped in befde3c (pkg/types/installconfig: Bump v1beta4 to v1, 2019-04-10, openshift#1589), but these v1beta4 references snuck in with 0ec07d0 (docs: vSphere installation docs, 2019-04-07, openshift#1545) and 0055065 (baremetal: add baremetal IPI platform, 2019-07-16, openshift#1873).
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Oct 30, 2019
…m provider() We've had the argument since the package landed in 0055065 (baremetal: add baremetal IPI platformo, 2019-07-16, openshift#1873), but it has never been used. Drop it to simplify the function calls, and to make it easier to use grep to answer questions like "does metal actually care about machineCIDR?" (apparently not).
alaypatel07
pushed a commit
to alaypatel07/installer
that referenced
this pull request
Nov 13, 2019
…m provider() We've had the argument since the package landed in 0055065 (baremetal: add baremetal IPI platformo, 2019-07-16, openshift#1873), but it has never been used. Drop it to simplify the function calls, and to make it easier to use grep to answer questions like "does metal actually care about machineCIDR?" (apparently not).
vrutkovs
pushed a commit
to vrutkovs/installer
that referenced
this pull request
Dec 2, 2019
…m provider() We've had the argument since the package landed in 0055065 (baremetal: add baremetal IPI platformo, 2019-07-16, openshift#1873), but it has never been used. Drop it to simplify the function calls, and to make it easier to use grep to answer questions like "does metal actually care about machineCIDR?" (apparently not).
jhixson74
pushed a commit
to jhixson74/installer
that referenced
this pull request
Dec 6, 2019
Most of our docs were bumped in befde3c (pkg/types/installconfig: Bump v1beta4 to v1, 2019-04-10, openshift#1589), but these v1beta4 references snuck in with 0ec07d0 (docs: vSphere installation docs, 2019-04-07, openshift#1545) and 0055065 (baremetal: add baremetal IPI platform, 2019-07-16, openshift#1873).
jhixson74
pushed a commit
to jhixson74/installer
that referenced
this pull request
Dec 6, 2019
…m provider() We've had the argument since the package landed in 0055065 (baremetal: add baremetal IPI platformo, 2019-07-16, openshift#1873), but it has never been used. Drop it to simplify the function calls, and to make it easier to use grep to answer questions like "does metal actually care about machineCIDR?" (apparently not).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all 👋
This adds experimental support for the baremetal IPI platform. Details about how to use it are in the docs/ directory. We have a prerequisite that there is an existing Ironic infrastructure, and that can be deployed with openshift-metal3/dev-scripts. We are working on moving that to the bootstrap VM, to avoid the dependency on another repository, but we are blocked until RHCOS has an updated version of libpod.
Other known issues that we are working on are tracked here.
This PR since it's initial opening has been broken up into some smaller PR's in addition to this one.