This repository has been archived by the owner on Aug 27, 2019. It is now read-only.
Add filter positional argument to clusters list #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhernand
reviewed
Aug 11, 2019
| Short: "List clusters", | ||
| Long: "List clusters by ID and Name", | ||
| Run: run, | ||
| Args: cobra.RangeArgs(0, 1), | ||
| RunE: run, |
There was a problem hiding this comment.
This change to RunE is nice. Is there any chance that you can do the same in all the other commands?
There was a problem hiding this comment.
Absolutely. Would that be better done in a follow up PR though (as to not balloon the size of this PR)?
There was a problem hiding this comment.
Yes, sure. A separate PR is better.
fahlmant
approved these changes
Aug 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a positional argument, use it as a name or ID filter. Compatible with the
--managedflag too.