Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter positional argument to clusters list #52

Merged
merged 2 commits into from Aug 13, 2019

Conversation

@cblecker
Copy link
Contributor

commented Aug 9, 2019

If there is a positional argument, use it as a name or ID filter. Compatible with the --managed flag too.

@cblecker cblecker force-pushed the cblecker:cluster-list-search branch 3 times, most recently from 8927b7e to adc4f09 Aug 10, 2019

@jhernand
Copy link
Collaborator

left a comment

Looks good. Just a very minor suggestion about comments.

@ALimaRedHat please take a look.

Show resolved Hide resolved cmd/uhc/cluster/list/list.go Outdated
Short: "List clusters",
Long: "List clusters by ID and Name",
Run: run,
Args: cobra.RangeArgs(0, 1),
RunE: run,

This comment has been minimized.

Copy link
@jhernand

jhernand Aug 11, 2019

Collaborator

This change to RunE is nice. Is there any chance that you can do the same in all the other commands?

This comment has been minimized.

Copy link
@cblecker

cblecker Aug 11, 2019

Author Contributor

Absolutely. Would that be better done in a follow up PR though (as to not balloon the size of this PR)?

This comment has been minimized.

Copy link
@jhernand

jhernand Aug 11, 2019

Collaborator

Yes, sure. A separate PR is better.

cblecker added some commits Aug 11, 2019

@cblecker cblecker force-pushed the cblecker:cluster-list-search branch from adc4f09 to 8304b0c Aug 11, 2019

@jhernand
Copy link
Collaborator

left a comment

Looks good, thanks @cblecker. I will wait a bit for @ALimaRedHat to review.

@ALimaRedHat
Copy link
Collaborator

left a comment

Looks good to me too

@jhernand jhernand merged commit d634ed4 into openshift-online:master Aug 13, 2019

1 check passed

ci.ext.devshift.net PR build
Details

@cblecker cblecker deleted the cblecker:cluster-list-search branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.