-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-33569: Remove duplicates code and cleanup #105
OCPBUGS-33569: Remove duplicates code and cleanup #105
Conversation
Hi @vikram-raj , I can still see some error wrt translation is missing. |
Translation issue is still present in local on hard reload. @vikram-raj created a thread in slack for that - https://redhat-internal.slack.com/archives/C011BL0FEKZ/p1715350433666159. We can get this in and look for translation related issue later. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lokanandaprabhu, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vikram-raj: This pull request references Jira Issue OCPBUGS-33569, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: sanketpathak. Note that only openshift-pipelines members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
d412f7f
into
openshift-pipelines:main
@vikram-raj: Jira Issue OCPBUGS-33569: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-33569 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cherry-pick release-v1.15.x |
@vikram-raj: new pull request created: #109 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
No description provided.