[DNM] enable immediate pruning of PipelineRuns in Tekton Results #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Satyam Bhardwaj <sabhardw@redhat.com>
ramessesii2
changed the title
|
As discussed, we'll wait for tektoncd/results#672 to be merged and deployed, and deactivate the default pruner before merging this PR. |
| @@ -19,7 +19,7 @@ spec: | |||
| "-auth_mode", | |||
| "token", | |||
| "-completed_run_grace_period", | |||
| "10m", | |||
| "-1", # anything less than 0 means completed PipelineRuns will be pruned immediately. | |||
There was a problem hiding this comment.
This might have undesirable consequences because the streaming of logs happens in a separate go routine which doesn't negotiate with the controller workflow and hence the deletion.
There is an open bug on this.
tektoncd/results#514
But it can be tested in staging. My guess there'll be a race condition.
|
Closed in favor of #905 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.