Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNM] enable immediate pruning of PipelineRuns in Tekton Results #868

Closed
wants to merge 1 commit into from
Closed

[DNM] enable immediate pruning of PipelineRuns in Tekton Results #868

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion operator/gitops/argocd/pipeline-service/tekton-results/watcher-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
"-auth_mode",
"token",
"-completed_run_grace_period",
"10m",
"-1", # anything less than 0 means completed PipelineRuns will be pruned immediately.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might have undesirable consequences because the streaming of logs happens in a separate go routine which doesn't negotiate with the controller workflow and hence the deletion.

https://github.com/tektoncd/results/blob/097030b9f52bf01149f7555d86b26f7a77327c60/pkg/watcher/reconciler/dynamic/dynamic.go#L323-L339

There is an open bug on this.
tektoncd/results#514

But it can be tested in staging. My guess there'll be a race condition.

]
securityContext:
readOnlyRootFilesystem: true