Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force controller & watcher goroutine to start "early" #1097

Merged

Conversation

vdemeester
Copy link
Member

Changes

Should probably fix some possible races with the configmap watcher

Submitter Checklist

  • β™½ Run make test lint before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI
  • πŸ“– If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
  • πŸ§ͺ 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
  • πŸ”Ž If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@sm43
Copy link
Contributor

sm43 commented Jan 5, 2023

/retest

@sm43 sm43 merged commit 3d0c2ad into openshift-pipelines:main Jan 5, 2023
@vdemeester vdemeester deleted the force-goroutines-to-start branch January 5, 2023 09:17
@sm43
Copy link
Contributor

sm43 commented Jan 11, 2023

we need to do this changes for watcher here

cc @savitaashture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants