Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of Force controller & watcher goroutine to start "early" #1101

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

savitaashture
Copy link
Member

Changes

  1. Fixed : Force controller & watcher goroutine to start "early" #1097 (comment)
  2. Added some prints to verify the configmap watcher issue

Signed-off-by: Savita Ashture sashture@redhat.com

Submitter Checklist

  • ♽ Run make test lint before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI
  • 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
  • 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
  • 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

pkg/params/run.go Outdated Show resolved Hide resolved
pkg/params/run.go Outdated Show resolved Hide resolved
@savitaashture savitaashture force-pushed the watcher-goroutine-fix branch 3 times, most recently from 2ea27b3 to 22e451b Compare January 11, 2023 13:42
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2023

Codecov Report

Merging #1101 (281548c) into main (600ab9e) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1101      +/-   ##
==========================================
- Coverage   63.08%   63.04%   -0.04%     
==========================================
  Files         106      106              
  Lines        6376     6380       +4     
==========================================
  Hits         4022     4022              
- Misses       1970     1974       +4     
  Partials      384      384              
Impacted Files Coverage Δ
pkg/reconciler/controller.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pkg/params/run.go Outdated Show resolved Hide resolved
pkg/params/run.go Outdated Show resolved Hide resolved
@sm43 sm43 merged commit e073ce2 into openshift-pipelines:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants