Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-14573: Agent-tui doesn't display full IPV6 addresses #24

Merged
merged 2 commits into from
Jun 5, 2023
Merged

OCPBUGS-14573: Agent-tui doesn't display full IPV6 addresses #24

merged 2 commits into from
Jun 5, 2023

Conversation

pawanpinjarkar
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels May 30, 2023
@openshift-ci-robot
Copy link

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-13212, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.13.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 30, 2023
@pawanpinjarkar
Copy link
Contributor Author

/cc @andfasano @bfournie please review

@openshift-ci
Copy link

openshift-ci bot commented May 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pawanpinjarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 30, 2023

@pawanpinjarkar: GitHub didn't allow me to request PR reviews from the following users: please, review.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @andfasano @bfournie please review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pawanpinjarkar
Copy link
Contributor Author

/retitle OCPBUGS-13212: Agent-tui doesn't display full IPV6 addresses

@openshift-ci openshift-ci bot changed the title OCPBUGS-13212: The ipv6 address can't fully displayed in confirm window in agent-tui OCPBUGS-13212: Agent-tui doesn't display full IPV6 addresses May 30, 2023
@pawanpinjarkar
Copy link
Contributor Author

After fix

Screenshot 2023-05-30 at 11 06 25 AM

andfasano
andfasano reviewed May 30, 2023
View reviewed changes
tools/agent_tui/ui/netstate_treeview.go Outdated
@@ -55,7 +55,7 @@ func (u *UI) ModalTreeView(netState net.NetState) (tview.Primitive, error) {
if err != nil {
return nil, err
}
width := 40
width := 45
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this cover also the worst case possible (39 chars IINW)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increased to 60 which seems sufficient.

@pawanpinjarkar
Copy link
Contributor Author

Screenshot 2023-05-30 at 3 49 43 PM

rwsu
rwsu reviewed Jun 2, 2023
View reviewed changes
Copy link
Contributor

@rwsu rwsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2023
@pawanpinjarkar
OCPBUGS-14573: Agent-tui doesn't display full IPV6 addresses
2addded 
Signed-off-by: Pawan Pinjarkar <ppinjark@redhat.com>
@pawanpinjarkar
Increased screen width
5d3877f 
Signed-off-by: Pawan Pinjarkar <ppinjark@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2023
@pawanpinjarkar pawanpinjarkar changed the title OCPBUGS-13212: Agent-tui doesn't display full IPV6 addresses OCPBUGS-14573: Agent-tui doesn't display full IPV6 addresses Jun 5, 2023
@openshift-ci-robot
Copy link

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-14573, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pawanpinjarkar
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 5, 2023
@openshift-ci-robot
Copy link

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-14573, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from mhanss June 5, 2023 14:28
@bfournie
Copy link

bfournie commented Jun 5, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 5, 2023

@pawanpinjarkar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit c763854 into openshift:main Jun 5, 2023
5 checks passed
@openshift-ci-robot
Copy link

@pawanpinjarkar: Jira Issue OCPBUGS-14573: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14573 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pawanpinjarkar
Copy link
Contributor Author

/cherry-pick release-4.13

@openshift-cherrypick-robot
Copy link

@pawanpinjarkar: cannot checkout release-4.13: error checking out release-4.13: exit status 1. output: error: pathspec 'release-4.13' did not match any file(s) known to git

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwsu rwsu rwsu left review comments

@andfasano andfasano andfasano left review comments

@celebdor celebdor Awaiting requested review from celebdor

@bfournie bfournie Awaiting requested review from bfournie

@mhanss mhanss Awaiting requested review from mhanss

Assignees

@rwsu rwsu

@bfournie bfournie

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pawanpinjarkar @openshift-ci-robot @bfournie @openshift-cherrypick-robot @rwsu @andfasano @openshift-merge-robot