OCPBUGS-14573: Adjust flex layout #25
Conversation
Signed-off-by: Pawan Pinjarkar <ppinjark@redhat.com>
|
/cc @andfasano |
openshift-ci-robot
added
jira/severity-low
|
@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-14573, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pawanpinjarkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| AddItem(treeView, height, 1, true). | ||
| AddItem(nil, 0, 1, false), width, 1, true). | ||
| AddItem(treeView, 0, 3, true). | ||
| AddItem(nil, 5, 1, false), 0, 2, true). |
There was a problem hiding this comment.
(nit: it could be more readable to extract the inner flex and assign it to a var)
No need to specify a fixed size also for the last column? Can you please attach a sshoot of how it looks like?
There was a problem hiding this comment.
the extra lines you see here are not related to the changes introduced but are related to my virt manager UI, as the I see same extra lines with the nightly image
|
/lgtm |
|
@pawanpinjarkar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@pawanpinjarkar: Jira Issue OCPBUGS-14573: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-14573 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.