Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose user/cluster information to APBs, example so created objects can be tagged with a label of user requesting. #470

Closed
jwmatthews opened this issue Oct 3, 2017 · 4 comments
Assignees
Labels
3.11 | release-1.3 Kubernetes 1.11 | Openshift 3.11 | Broker release-1.3 feature

Comments

@jwmatthews
Copy link
Member

Feature

When running an APB it would be helpful if information such as below was available for the APB to obtain and process.

  • User
  • Service ID
  • Namespace

For example, creating an APB for provisioning a remote resource on a cloud provider. It would be useful if the APB could annotate the created resources with some information about where the request came from such as: cluster_url, requesting_user, namespace, related service id

@rthallisey
Copy link
Contributor

Related to #470 . We could use the kubernetes downward API to gather some of this information and re post it as an annotation. @maleck13 is working on a module that is doing something similar ansibleplaybookbundle/ansible-asb-modules#9 .

@rthallisey rthallisey added the 3.10 | release-1.2 Kubernetes 1.10 | Openshift 3.10 | Broker release-1.2 label Jan 18, 2018
@shawn-hurley
Copy link
Contributor

I think that we may also want to see if whatever mechanism we decide on can also be used to pass along the proxy configs we may want to consider that as well?

@jmrodri jmrodri self-assigned this Mar 6, 2018
@djzager
Copy link
Member

djzager commented Mar 6, 2018

Just to add some info, what values are given to an APB:

$ oc logs -n localregistry-mediawiki-apb-prov-7zxb5 apb-6dd23918-9225-4bd0-ad34-75bc5d15fb31
+ [[ provision --extra-vars {
"_apb_plan_id":"default",
"_apb_service_class_id":"c23ec213bb8dea1577230c5ce005b9c2",
"_apb_service_instance_id":"54636ad3-0378-49a1-a494-f97d0a0daf8e",
"cluster":"openshift",
"mediawiki_admin_pass":"pass",
"mediawiki_admin_user":"admin",
"mediawiki_db_schema":"mediawiki",
"mediawiki_site_lang":"en",
"mediawiki_site_name":"MediaWiki",
"namespace":"bazproject"} == *\s\2\i\/\a\s\s\e\m\b\l\e* ]]
+ ACTION=provision

Could also look at https://github.com/openshift/ansible-service-broker/blob/master/docs/service-bundle.md

@jmrodri jmrodri added 3.11 | release-1.3 Kubernetes 1.11 | Openshift 3.11 | Broker release-1.3 and removed 3.10 | release-1.2 Kubernetes 1.10 | Openshift 3.10 | Broker release-1.2 labels Jun 5, 2018
@jmrodri
Copy link
Contributor

jmrodri commented Aug 7, 2018

I think we have enough information being exposed right now. No new requests have come in recently. Closing this as DONE!

@jmrodri jmrodri closed this as completed Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.11 | release-1.3 Kubernetes 1.11 | Openshift 3.11 | Broker release-1.3 feature
Projects
None yet
Development

No branches or pull requests

5 participants