Bug 1508084 - Add ServiceClassID and ServiceInstanceID params during provision and bind #515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #481
and part of #470
Changes proposed in this pull request
Note
Not currently passing through the user as is mentioned in issue 470. Is this still something that is wanted? I can see the user is resolved and could be passed down to the broker methods.
If we wanted to pass the user would we pass the entire user object or just the username perhaps?
Testing
The unit tests for the broker seemed a bit lacking so tested this manually: The apb and asb logs appeared as follows:
Is this sufficient?