Removing redundancy in dao for issue #63 #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also fixing golint things like comments on export methods and structs
jmrodri
suggested changes
May 11, 2017
pkg/dao/dao.go
Outdated
| @@ -10,11 +10,13 @@ import ( | |||
| logging "github.com/op/go-logging" | |||
| ) | |||
|
|
|||
| //Config - confg holds etcd host and port. | |||
There was a problem hiding this comment.
Add a space after the // not a golint check, but a zeus check. I prefer the space 😄
pkg/dao/dao.go
Outdated
| func (d *Dao) GetSpec(id string) (*apb.Spec, error) { | ||
| raw, err := d.GetRaw(specKey(id)) | ||
| spec := &apb.Spec{} | ||
| err := d.getObject(specKey(id), spec) |
There was a problem hiding this comment.
Let's also change it to include the error check in the same line.
if err := d.getObject(specKey(id), spec); err != nil {
return nil, err
}
I know it will result in more changes, but I think it looks better than what we had.
| } | ||
| return d.SetRaw(key, payload) | ||
| } | ||
|
|
jmrodri
approved these changes
May 11, 2017
Closed
shawn-hurley
pushed a commit
to shawn-hurley/ansible-service-broker
that referenced
this pull request
Nov 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #63