Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD-353: Rename csi.shared-resources.openshift.io driver to csi.sharedresource.openshift.io #1023

Merged
merged 1 commit into from Oct 14, 2021
Merged

BUILD-353: Rename csi.shared-resources.openshift.io driver to csi.sharedresource.openshift.io #1023

merged 1 commit into from Oct 14, 2021

Conversation

coreydaley
Copy link
Member

Hopefully this is the last of the shared resources updates.
I think we got them all this time.

@coreydaley
Copy link
Member Author

/assign @gabemontero @deads2k

@gabemontero
Copy link
Contributor

/lgtm

thanks for the catch @coreydaley

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2021
@gabemontero
Copy link
Contributor

gabemontero commented Oct 7, 2021

/retitle BUILD-353: Renaming csi.shared-resources.openshift.io to csi.sharedresource.openshift.io

@openshift-ci openshift-ci bot changed the title Renaming csi.shared-resources.openshift.io to csi.sharedresource.openshift.io BUILD-353: Renaming csi.shared-resources.openshift.io to csi.sharedresource.openshift.io Oct 7, 2021
@coreydaley coreydaley changed the title BUILD-353: Renaming csi.shared-resources.openshift.io to csi.sharedresource.openshift.io BUILD-353: Add csi.sharedresource.openshift.io driver Oct 13, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2021
@coreydaley
Copy link
Member Author

/assign @sttts

@coreydaley coreydaley changed the title BUILD-353: Add csi.sharedresource.openshift.io driver BUILD-353: Rename csi.shared-resources.openshift.io driver to csi.sharedresource.openshift.io Oct 14, 2021
@sttts
Copy link
Contributor

sttts commented Oct 14, 2021

We know that this technically break validation for an existing object of the changed name. But these objects are internal, only created by the operator with a feature gate, and it is very unlikely that they exist in a real cluster. Moreover, @coreydaley tested manually that a wrongly named object can be deleted (in the worst case).

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, gabemontero, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2021
@openshift-merge-robot openshift-merge-robot merged commit b692084 into openshift:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants