BUILD-353: csi driver, crd name changes #9

gabemontero · 2021-09-28T13:16:28Z

the group name was previouisly incorrect, but the mistake happened to land on the choice decided upon (sharedresource vs. storage)

/assign @coreydaley
/assign @adambkaplan

openshift-ci · 2021-09-28T13:16:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [gabemontero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gabemontero · 2021-09-28T13:17:37Z

manifests/05_clusterrole.yaml

@@ -271,7 +271,8 @@ rules:
 - apiGroups:
  - sharedresource.openshift.io
  resources:
-    - shares
+    - sharedConfigs


notice up in line 272 here .... with all the various rename churn, we missed changing this to what is now the "old" value, storage.openshift.io

we go lucky, in that we wanted on sharedresource.openshift.io

gabemontero · 2021-09-28T13:18:40Z

I suspect the e2e-aws-csi-driver will fail until openshift/csi-driver-shared-resource#55 merges

if it doesn't, we may need to investigate whey @adambkaplan @coreydaley

gabemontero · 2021-09-28T14:08:46Z

the failure was

 oc apply -f ./csi-driver-yaml-that-will-live-in-cluster-storage-operator.yaml
The ClusterCSIDriver "csi.sharedresource.openshift.io" is invalid: metadata.name: Unsupported value: "csi.sharedresource.openshift.io": supported values: "ebs.csi.aws.com", "efs.csi.aws.com", "disk.csi.azure.com", "pd.csi.storage.gke.io", "cinder.csi.openstack.org", "csi.vsphere.vmware.com", "manila.csi.openstack.org", "csi.ovirt.org", "csi.kubevirt.io", "csi.shared-resources.openshift.io"
make: *** [deploy] Error 1

Maybe I missed a spot?

gabemontero · 2021-09-28T14:14:13Z

OK it is from openshift/api: ./vendor/github.com/openshift/api/operator/v1/types_csi_cluster_driver.go: SharedResourcesCSIDriver CSIDriverName = "csi.shared-resources.openshift.io"

so when @coreydaley 's openshift/api openshift/api#979 with the renames land, we vendor the update here, and we go from there

presumably openshift/csi-driver-shared-resource#55 will merge before all that

otaviof · 2021-10-04T08:58:39Z

In general it looks good, I hope the CI issues will solved soon 👍🏼

gabemontero · 2021-10-05T17:03:21Z

actually we'll need minimally openshift/api#1019 to merge and vendor that in as part of this PR before we can move forward

I don't think we need @coreydaley to vendor in openshift/api#979 and openshift/api#1019 into the driver repo to get the e2e's to pass from here, given my previous BUILD-353 efforts, but the proof will be in the e2e run

gabemontero · 2021-10-07T14:16:01Z

swell ... go-vet is reporting errors in CI I am not seeing locally

investigating

gabemontero · 2021-10-07T14:24:28Z

nuked all of /vendor locally then rebuilt ... I think it added the missing dir's CI's go vet was complaining about

otherwise, may still need to vendor in again after openshift/api#1023 merges (yet another rename spot we missed that @coreydaley just discovered)

gabemontero · 2021-10-07T18:46:42Z

yeah looks like we need openshift/api#1023 merged and vendored in here

gabemontero · 2021-10-12T17:20:26Z

in case openshift/csi-driver-shared-resource#57 has some bearing

/retest

gabemontero · 2021-10-13T17:16:04Z

perhaps this was dependent on promotion / mirroring that took place recently

/retest

gabemontero · 2021-10-14T14:09:29Z

seemingly unrelated cluster install problem this time

/retest

coreydaley · 2021-10-14T14:25:31Z

manifests/05_clusterrole.yaml

@@ -271,7 +271,8 @@ rules:
 - apiGroups:
  - sharedresource.openshift.io
  resources:
-    - shares
+    - sharedConfigs


Should this be sharedconfigmaps?

Suggested change

- sharedConfigs

- sharedconfigmaps

coreydaley · 2021-10-14T14:27:21Z

manifests/05_clusterrole.yaml

@@ -271,7 +271,8 @@ rules:
 - apiGroups:
  - sharedresource.openshift.io
  resources:
-    - shares
+    - sharedConfigs
+    - sharedSecrets


I think this should be sharedsecrets

Suggested change

- sharedSecrets

- sharedsecrets

gabemontero · 2021-10-14T15:00:44Z

thanks @coreydaley - update pushed / fingers crossed

coreydaley · 2021-10-14T15:35:53Z

manifests/05_clusterrole.yaml

@@ -271,7 +271,8 @@ rules:
 - apiGroups:
  - sharedresource.openshift.io
  resources:
-    - shares
+    - sharedconfigs


sharedconfigmaps

Suggested change

- sharedconfigs

- sharedconfigmaps

coreydaley

I think it should be sharedconfigmaps

gabemontero · 2021-10-14T15:39:17Z

yep fixed thanks @coreydaley

coreydaley · 2021-10-14T15:40:13Z

/lgtm

openshift-bot · 2021-10-14T17:05:58Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-14T17:29:58Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

gabemontero · 2021-10-14T17:38:20Z

/hold

CI is currently busted https://coreos.slack.com/archives/CEKNRGF25/p1634230288225500

coreydaley · 2021-10-14T18:54:56Z

/retest

coreydaley · 2021-10-14T20:35:35Z

/retest

gabemontero · 2021-10-15T00:04:59Z

Well we are back to

The ClusterCSIDriver "csi.sharedresource.openshift.io" is invalid: metadata.name: Unsupported value: "csi.sharedresource.openshift.io": supported values: "ebs.csi.aws.com", "efs.csi.aws.com", "disk.csi.azure.com", "pd.csi.storage.gke.io", "cinder.csi.openstack.org", "csi.vsphere.vmware.com", "manila.csi.openstack.org", "csi.ovirt.org", "csi.kubevirt.io", "csi.shared-resources.openshift.io"

since I've vendored the rename into this repo @coreydaley that must mean either that

a) we need your openshift/openshift-apiserver PR openshift/openshift-apiserver#244
b) we need the analogous change minimally in cluster storage operator https://github.com/openshift/cluster-storage-operator/blob/master/vendor/github.com/openshift/api/operator/v1/types_csi_cluster_driver.go#L54
c) both a) and b)

coreydaley · 2021-10-15T11:39:01Z

/retest

coreydaley · 2021-10-15T12:02:43Z

Opened openshift/cluster-storage-operator#224 which will hopefully address this.

coreydaley · 2021-10-15T13:58:59Z

/retest
Not sure how long it will take for the newest cluster-storage-operator image to get published, hopefully that fixes this.

coreydaley · 2021-10-15T14:47:55Z

/retest
I am not convinced that the last run picked up the latest cluster storage operator image.
If this one fails, then it could be the openshift-apiserver needs to be updated first

…t, but the mistake happened to land on the choice decided upon (sharedresource vs. storage)

coreydaley · 2021-10-15T18:22:29Z

/lgtm

gabemontero · 2021-10-15T18:29:29Z

/hold cancel

openshift-ci bot assigned adambkaplan and coreydaley Sep 28, 2021

openshift-ci bot requested review from coreydaley and otaviof September 28, 2021 13:16

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2021

gabemontero commented Sep 28, 2021

View reviewed changes

gabemontero force-pushed the crd-group-driver-rename-chgs branch from c97e5ea to 483bac5 Compare October 7, 2021 14:04

gabemontero force-pushed the crd-group-driver-rename-chgs branch from 483bac5 to 3c56ad5 Compare October 7, 2021 14:22

bump(*): openshift/api,client-go,library-go

49a4be1

gabemontero force-pushed the crd-group-driver-rename-chgs branch from 3c56ad5 to 00f0b8f Compare October 14, 2021 12:40

coreydaley reviewed Oct 14, 2021

View reviewed changes

gabemontero force-pushed the crd-group-driver-rename-chgs branch from 00f0b8f to afbed8d Compare October 14, 2021 14:59

coreydaley reviewed Oct 14, 2021

View reviewed changes

coreydaley requested changes Oct 14, 2021

View reviewed changes

gabemontero force-pushed the crd-group-driver-rename-chgs branch from afbed8d to d5028c8 Compare October 14, 2021 15:38

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2021

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2021

coreydaley mentioned this pull request Oct 15, 2021

bump openshift/api to get csi.sharedresource.openshift.io openshift/cluster-storage-operator#224

Merged

csi driver, crd name changes; the group name was previouisly incorrec…

e35974c

…t, but the mistake happened to land on the choice decided upon (sharedresource vs. storage)

gabemontero force-pushed the crd-group-driver-rename-chgs branch from d5028c8 to e35974c Compare October 15, 2021 17:29

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2021

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2021

openshift-merge-robot merged commit cbd681f into openshift:master Oct 15, 2021

gabemontero deleted the crd-group-driver-rename-chgs branch October 15, 2021 18:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BUILD-353: csi driver, crd name changes #9

BUILD-353: csi driver, crd name changes #9

gabemontero commented Sep 28, 2021

openshift-ci bot commented Sep 28, 2021

gabemontero Sep 28, 2021

gabemontero commented Sep 28, 2021

gabemontero commented Sep 28, 2021

gabemontero commented Sep 28, 2021 •

edited

otaviof commented Oct 4, 2021 •

edited

gabemontero commented Oct 5, 2021 •

edited by openshift-ci bot

gabemontero commented Oct 7, 2021

gabemontero commented Oct 7, 2021 •

edited

gabemontero commented Oct 7, 2021

gabemontero commented Oct 12, 2021

gabemontero commented Oct 13, 2021

gabemontero commented Oct 14, 2021

coreydaley Oct 14, 2021 •

edited

coreydaley Oct 14, 2021 •

edited

gabemontero commented Oct 14, 2021

coreydaley Oct 14, 2021 •

edited

coreydaley left a comment

gabemontero commented Oct 14, 2021

coreydaley commented Oct 14, 2021

openshift-bot commented Oct 14, 2021

openshift-bot commented Oct 14, 2021

gabemontero commented Oct 14, 2021

coreydaley commented Oct 14, 2021

coreydaley commented Oct 14, 2021

gabemontero commented Oct 15, 2021

coreydaley commented Oct 15, 2021

coreydaley commented Oct 15, 2021

coreydaley commented Oct 15, 2021

coreydaley commented Oct 15, 2021

coreydaley commented Oct 15, 2021

gabemontero commented Oct 15, 2021

BUILD-353: csi driver, crd name changes #9

BUILD-353: csi driver, crd name changes #9

Conversation

gabemontero commented Sep 28, 2021

openshift-ci bot commented Sep 28, 2021

gabemontero Sep 28, 2021

Choose a reason for hiding this comment

gabemontero commented Sep 28, 2021

gabemontero commented Sep 28, 2021

gabemontero commented Sep 28, 2021 • edited

otaviof commented Oct 4, 2021 • edited

gabemontero commented Oct 5, 2021 • edited by openshift-ci bot

gabemontero commented Oct 7, 2021

gabemontero commented Oct 7, 2021 • edited

gabemontero commented Oct 7, 2021

gabemontero commented Oct 12, 2021

gabemontero commented Oct 13, 2021

gabemontero commented Oct 14, 2021

coreydaley Oct 14, 2021 • edited

Choose a reason for hiding this comment

coreydaley Oct 14, 2021 • edited

Choose a reason for hiding this comment

gabemontero commented Oct 14, 2021

coreydaley Oct 14, 2021 • edited

Choose a reason for hiding this comment

coreydaley left a comment

Choose a reason for hiding this comment

gabemontero commented Oct 14, 2021

coreydaley commented Oct 14, 2021

openshift-bot commented Oct 14, 2021

openshift-bot commented Oct 14, 2021

gabemontero commented Oct 14, 2021

coreydaley commented Oct 14, 2021

coreydaley commented Oct 14, 2021

gabemontero commented Oct 15, 2021

coreydaley commented Oct 15, 2021

coreydaley commented Oct 15, 2021

coreydaley commented Oct 15, 2021

coreydaley commented Oct 15, 2021

coreydaley commented Oct 15, 2021

gabemontero commented Oct 15, 2021

gabemontero commented Sep 28, 2021 •

edited

otaviof commented Oct 4, 2021 •

edited

gabemontero commented Oct 5, 2021 •

edited by openshift-ci bot

gabemontero commented Oct 7, 2021 •

edited

coreydaley Oct 14, 2021 •

edited

coreydaley Oct 14, 2021 •

edited

coreydaley Oct 14, 2021 •

edited